netdev
[Top] [All Lists]

Re: SIOCADDMULTI for unicast broken

To: netdev@xxxxxxxxxxx
Subject: Re: SIOCADDMULTI for unicast broken
From: Krzysztof Halasa <khc@xxxxxxxxx>
Date: 06 Jan 2003 16:00:33 +0100
In-reply-to: <3E163E4D.5090007@xxxxxxxxx>
References: <Pine.LNX.4.44.0301032029540.29812-100000@xxxxxxxxxxxxxxxxx> <3E163CBB.30206@xxxxxxxxxxxxxxx> <3E163E4D.5090007@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Jeff Garzik <jgarzik@xxxxxxxxx> writes:

> No!  procfs additions are discouraged.  sysfs in 2.5.x if you _must_
> do this, but SIOCDEVPRIVATE or just flat out maintaining a kernel
> patch against a stable kernel tree would be much preferred, I think.

Still, SIOCDEVPRIVATE should _not_, in my opinion, be used for anything
but hacks.
For example, we should stop using it for configuring ethernet bridges:

net/bridge/br_device.c: if (cmd != SIOCDEVPRIVATE)
-- 
Krzysztof Halasa
Network Administrator


<Prev in Thread] Current Thread [Next in Thread>