netdev
[Top] [All Lists]

Re: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size)

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size)
From: Alan <alan@xxxxxxxxxxxxxxxxxxx>
Date: 21 Jan 2003 02:17:28 +0000
Cc: Dave Jones <davej@xxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, alan@xxxxxxxxxx, akpm@xxxxxxxxx
In-reply-to: <20030117174928.GA8304@gtf.org>
Organization:
References: <20030117145357.GA1139@paradigm.rfc822.org> <20030117160840.GR12676@stingr.net> <20030117162818.GA1074@gtf.org> <20030117172719.GA31343@codemonkey.org.uk> <20030117174928.GA8304@gtf.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 2003-01-17 at 17:49, Jeff Garzik wrote:
> > Whilst on the subject of magic numbers in net drivers, did we ever get
> > to the bottom of 2.4's ChangeSet 1.587.9.20 
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.48/split-dj1/net-cs89x0-media-corrections.diff
> 
> 
> IIRC it came from -ac tree without explanation, and I think akpm said it
> broke stuff.  Since it has an alive maintainer (akpm), I would rather
> let Alan and Andrew fight it out :)  Whatever they decide is fine with
> me for 2.5.

I've had no reports I remember about it breaking stuff, and several that
it fixed stuff. It also seems to match the documentation. Its been in -ac
for ages


<Prev in Thread] Current Thread [Next in Thread>