Re: qdisc_restart locking bug?

[kuznet@xxxxxxxxxxxxx]

Hello!

> When dev->hard_start_xmit() is called from qdisc_restart(), 
> dev->queue_lock is dropped, 

Using spin_unlock(). softirqs are not enabled.

>                       and then re-acquired using only spin_lock().

Yes.


> So, doesn't qdisc_restart need s/spin_lock/spin_lock_bh/ for 
> dev->queue_lock?

It need not.

Alexey