netdev
[Top] [All Lists]

Re: [PATCH] IPv6: Sysctl for ICMPv6 Rate Limitation

To: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Subject: Re: [PATCH] IPv6: Sysctl for ICMPv6 Rate Limitation
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Thu, 24 Oct 2002 16:23:55 +0900 (JST)
Cc: pekkas@xxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0210240858060.8872-100000@xxxxxxxxxx>
Organization: USAGI Project
References: <20021024.145551.130454003.yoshfuji@xxxxxxxxxxxxxx> <Pine.LNX.4.44.0210240858060.8872-100000@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <Pine.LNX.4.44.0210240858060.8872-100000@xxxxxxxxxx> (at Thu, 24 Oct 
2002 08:59:16 +0300 (EEST)), Pekka Savola <pekkas@xxxxxxxxxx> says:

> > > Does this rate-limit all ICMPv6 packets or just ICMPv6 error messages (as 
> > > specified in ICMPv6 specifications).
> > > 
> > > If all, I believe the default of rate-limiting everything is unacceptable.
> > 
> > This patch just adds sysctl.  It is my documentation error...
> > is s/ICMPv6 packets/ICMPv6 error packets/ ok?
> > 
> > (I need to do s/100/HZ/, too; This also lives in ICMP(v4)).
> 
> That change fine with me, thanks.

Please apply the following patch on top of the previous 
"Sysctl for ICMPv6 Rate Limitation" patch.  Thanks.

Index: Documentation/networking/ip-sysctl.txt
===================================================================
RCS file: 
/cvsroot/usagi/usagi-backport/linux24/Documentation/networking/ip-sysctl.txt,v
retrieving revision 1.1.1.1.44.1
retrieving revision 1.1.1.1.44.1.2.2
diff -u -r1.1.1.1.44.1 -r1.1.1.1.44.1.2.2
--- Documentation/networking/ip-sysctl.txt      23 Oct 2002 17:50:19 -0000      
1.1.1.1.44.1
+++ Documentation/networking/ip-sysctl.txt      24 Oct 2002 07:03:46 -0000      
1.1.1.1.44.1.2.2
@@ -316,7 +316,7 @@
        Limit the maximal rates for sending ICMP packets whose type matches
        icmp_ratemask (see below) to specific targets.
        0 to disable any limiting, otherwise the maximal rate in jiffies(1)
-       Default: 100
+       Default: HZ
 
 icmp_ratemask - INTEGER
        Mask made of ICMP types for which rates are being limited.
@@ -562,9 +562,9 @@
 
 icmp/*:
 ratelimit - INTEGER
-       Limit the maximal rates for sending ICMPv6 packets.
+       Limit the maximal rates for sending ICMPv6 error packets.
        0 to disable any limiting, otherwise the maximal rate in jiffies(1)
-       Default: 100
+       Default: HZ
 
 IPv6 Update by:
 Pekka Savola <pekkas@xxxxxxxxxx>

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA


<Prev in Thread] Current Thread [Next in Thread>