netdev
[Top] [All Lists]

Re: [Patch 2.5.43] IpInDelivers, IpInDiscards

To: niv@xxxxxxxxxx
Subject: Re: [Patch 2.5.43] IpInDelivers, IpInDiscards
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 17 Oct 2002 15:24:52 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0210171428520.3131-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <Pine.LNX.4.44.0210171428520.3131-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Nivedita Singhvi <niv@xxxxxxxxxx>
   Date: Thu, 17 Oct 2002 14:49:04 -0700 (PDT)

   This patch cleans up the use of the SNMP stats counters
   IpInDelivers and IpInDiscards (and the v6 counterparts). 
   A patch to address some of this had been submitted a while 
   ago by Mark Price.

I agree with with.  I just have some minor troubles with some of
the changes to ip_input.c

Specifically, the ip_rcv_finish() and ip_rcv() counter bumps
should all move to right below the drop: label which exists in
both functions.

Make this fixup, and I'll apply the patch.

Thanks.


<Prev in Thread] Current Thread [Next in Thread>