David S. Miller wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Sat, 05 Oct 2002 12:27:15 -0700
This patch looks good too, though the (vlan_id < 0) test
is redundant since vlan_id is an unsigned number. For
clarity of code, I wouldn't mind if it stayed in though.
VLAN ID zero is illegal. You should not use ifconfig
with a VID of zero.
As someone mentioned, vlan of 0 may be used to do a priority-only
type of VLAN. I don't know how much this makes sense though...
If we do decide to restrict it, the right place to restrict is in
the creation clause, not the deletion code, as exists now.
--
Ben Greear <greearb@xxxxxxxxxxxxxxx> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
|