netdev
[Top] [All Lists]

Re: VLAN patches

To: greearb@xxxxxxxxxxxxxxx
Subject: Re: VLAN patches
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 05 Oct 2002 21:17:53 -0700 (PDT)
Cc: Bjorn.Andersson@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <3D9F3D13.3080904@xxxxxxxxxxxxxxx>
References: <3D980A10.8B06F2C2@xxxxxxxxxxxxxxx> <3D9F3D13.3080904@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
   Date: Sat, 05 Oct 2002 12:27:15 -0700

   This patch looks good too, though the (vlan_id < 0) test
   is redundant since vlan_id is an unsigned number.  For
   clarity of code, I wouldn't mind if it stayed in though.
   
VLAN ID zero is illegal.  You should not use ifconfig
with a VID of zero.


<Prev in Thread] Current Thread [Next in Thread>