This patch looks good too, though the (vlan_id < 0) test
is redundant since vlan_id is an unsigned number. For
clarity of code, I wouldn't mind if it stayed in though.
Andersson Björn wrote:
Hi,
I hope you are the right receiver of 8021q-patches.
We are running SuSe 8.0, i.e kernel 2.4.18.
- If we try to remove a vlan with VID 0, ifconfig stops working
completly.
We fixed it with vlan.c.patch.
------------------------------------------------------------------------
--- linux-2.4.18.SuSE/net/8021q/vlan.c.orig Wed Mar 27 13:57:17 2002
+++ linux-2.4.18.SuSE/net/8021q/vlan.c Wed Sep 18 13:19:13 2002
@@ -207,7 +207,7 @@
#endif
/* sanity check */
- if ((vlan_id >= VLAN_VID_MASK) || (vlan_id <= 0))
+ if ((vlan_id >= VLAN_VID_MASK) || (vlan_id < 0))
return -EINVAL;
spin_lock_bh(&vlan_group_lock);
--
Ben Greear <greearb@xxxxxxxxxxxxxxx> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
|