netdev
[Top] [All Lists]

Re: [BK PATCH] Make eth.c independent of dev->hard_header_len

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [BK PATCH] Make eth.c independent of dev->hard_header_len
From: Kai Germaschewski <kai-germaschewski@xxxxxxxxx>
Date: Sun, 29 Sep 2002 14:09:11 -0500 (CDT)
Cc: "David S. Miller" <davem@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <3D974A3D.40207@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 29 Sep 2002, Jeff Garzik wrote:

> Kai Germaschewski wrote:
> > --- a/drivers/net/hamachi.c Sun Sep 29 13:10:36 2002
> > +++ b/drivers/net/hamachi.c Sun Sep 29 13:10:36 2002
> 
> I would prefer to keep the code inside TX_CHECKSUM in hamachi.c, hoping 
> somebody will complete it, not rip it out :)

I didn't really rip out anything. I just removed code cut'n'pasted from
net/ethernet/eth.c (+ slight modification to handle dev->hard_header_len
!= ETH_HLEN), since after the change we can use the generic
eth_trans_type() directly. The TX checksum thing is not at all affected by
that piece of code.

--Kai



<Prev in Thread] Current Thread [Next in Thread>