netdev
[Top] [All Lists]

Re: [PATCH] IPv6: Improvement of Source Address Selection

To: kuznet@xxxxxxxxxxxxx
Subject: Re: [PATCH] IPv6: Improvement of Source Address Selection
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 27 Sep 2002 19:35:41 -0700 (PDT)
Cc: yoshfuji@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <200209280228.GAA02633@xxxxxxxxxxxxx>
References: <20020927.182833.66704359.davem@xxxxxxxxxx> <200209280228.GAA02633@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: kuznet@xxxxxxxxxxxxx
   Date: Sat, 28 Sep 2002 06:28:29 +0400 (MSD)

   > Otherwise I have no problems with the patch, Alexey?
   
   I have... The implementation is bad. Source address must be retieved
   from route, not running this elephant function each packet.
   
This only runs at connect time, and when NULL fl->fl6_src is seen
by ip6_build_xmit() (this means RAW,UDP,ICMP which must make these
decisions anyways).

Is there really so much computation to be saved by moving this
to ipv6 route?


<Prev in Thread] Current Thread [Next in Thread>