netdev
[Top] [All Lists]

Re: [PATCH] Networking: send-to-self [link to non-broken patch this

To: greearb@xxxxxxxxxxxxxxx (Ben Greear)
Subject: Re: [PATCH] Networking: send-to-self [link to non-broken patch this
From: kuznet@xxxxxxxxxxxxx
Date: Fri, 27 Sep 2002 19:01:53 +0400 (MSD)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3D93FBA6.6080905@xxxxxxxxxxxxxxx> from "Ben Greear" at Sep 26, 2 11:33:10 pm
Sender: netdev-bounce@xxxxxxxxxxx
Hello!

> I have a question though:  If this method is ever called to send an RST,
> will it work?

Work for what? This method is used when you have no socket in the system
matching to this skb. :-)

> What about this part, do you think it is not needed either?  It appeared
> to me that w/out this, the sending socket and the receiving socket
...
> sending one, unfortunately).

No, this is impossible. addrs/ports identity identifies socket unambiguously.

But even this does not matter, your patch is noop by much simpler pure
"syntactical" reason, it copies req->bound_dev_if from listening socket.
And after this the check in lookup req degenerates to TRUE __identitically__.
 :-)

Alexey


<Prev in Thread] Current Thread [Next in Thread>