netdev
[Top] [All Lists]

Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000
From: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Date: Mon, 16 Sep 2002 19:48:37 -0400
Cc: dwmw2@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, todd-lkml@xxxxxxxxxxxxx, hadi@xxxxxxxxxx, tcw@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, pfeather@xxxxxxxxxx
Organization: MandrakeSoft
References: <12116.1032216780@redhat.com> <12293.1032217399@redhat.com> <3D86645F.5030401@mandrakesoft.com> <20020916.160210.70782700.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826
David S. Miller wrote:
From: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Date: Mon, 16 Sep 2002 19:08:15 -0400
I was rather disappointed when file->file sendfile was [purposefully?] broken in 2.5.x...


What change made this happen?


I dunno when it happened, but 2.5.x now returns EINVAL for all file->file cases.

In 2.4.x, if sendpage is NULL, file_send_actor in mm/filemap.c faked a call to fops->write().
In 2.5.x, if sendpage is NULL, EINVAL is unconditionally returned.



<Prev in Thread] Current Thread [Next in Thread>