Re: [PATCH] minor socket ioctl cleanup for 2.5.30

[kuznet@xxxxxxxxxxxxx]

Hello!

> > Do we really want to do this?  What if some socket family either
> > doesn't want to support it or wants to handle it differently?
> 
> I rather think we do.  It's analagous to saying "What if some filesystem
> either doesn't want to support it or wants to handle it differently?"
> -- tough!  This is unix and filesystems (socket families) support this.

No, this is not true. This creepy ioctl is specific to TCP
(well, x.25 also uses SIGURG), which use kill*(sk->proc, SIGURG) directly.

Probably, it is better to move sk->proc to TCP private data,
this ioctl to tcp_ioctl(). Or... find a way to get rid of this completely,
not breaking compatibility with a few BSDish applications.

Alexey