[Top] [All Lists]

Re: [PATCH] fix HIPQUAD macro in kernel.h

To: ak@xxxxxxx
Subject: Re: [PATCH] fix HIPQUAD macro in kernel.h
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 08 Aug 2002 07:48:53 -0700 (PDT)
Cc: laforge@xxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20020808134113.A2552@xxxxxxxxxxxxx>
References: <20020808133112.E11828@xxxxxxxxxxxxxxxxxxxxxxx> <20020808134113.A2552@xxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
   From: Andi Kleen <ak@xxxxxxx>
   Date: Thu, 8 Aug 2002 13:41:13 +0200
   That change is wrong. IP address should be always in network order
   (=BE) while in kernel.

He's fixing the HIPQUAD ('H' as in 'host') not NIPQUAD ('N' as in
'network') macro.

If you disagree with people using HIPQUAD at all, recommend that
it be deleted.  Until then, it ought to be fixed :-)

<Prev in Thread] Current Thread [Next in Thread>