Re: [PATCH] fix HIPQUAD macro in kernel.h

netdev

Re: [PATCH] fix HIPQUAD macro in kernel.h

To:	Harald Welte <laforge@xxxxxxxxxxxx>
Subject:	Re: [PATCH] fix HIPQUAD macro in kernel.h
From:	Andi Kleen <ak@xxxxxxx>
Date:	Thu, 8 Aug 2002 13:41:13 +0200
Cc:	David Miller <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20020808133112.E11828@xxxxxxxxxxxxxxxxxxxxxxx>
References:	<20020808133112.E11828@xxxxxxxxxxxxxxxxxxxxxxx>
Sender:	owner-netdev@xxxxxxxxxxx
User-agent:	Mutt/1.3.22.1i

On Thu, Aug 08, 2002 at 01:31:12PM +0200, Harald Welte wrote:
> Hi Dave!
> 
> Below is a fix for the HIPQUAD macro in kernel.h.  The macro is currently
> not endian-aware - it just assumes running on a little-endian machine.
> 
> If you don't like the #ifdefs in kernel.h, the macros could be moved into 
> include/linux/byteorder/.
> 
> Please apply, thanks

That change is wrong. IP address should be always in network order (=BE) 
while in kernel.

-Andi

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] fix HIPQUAD macro in kernel.h, Harald Welte Re: [PATCH] fix HIPQUAD macro in kernel.h, Andi Kleen <= Re: [PATCH] fix HIPQUAD macro in kernel.h, Harald Welte Re: [PATCH] fix HIPQUAD macro in kernel.h, David S. Miller Re: [PATCH] fix HIPQUAD macro in kernel.h, David S. Miller

Previous by Date:	[PATCH] fix HIPQUAD macro in kernel.h, Harald Welte
Next by Date:	Re: [PATCH] fix HIPQUAD macro in kernel.h, Harald Welte
Previous by Thread:	[PATCH] fix HIPQUAD macro in kernel.h, Harald Welte
Next by Thread:	Re: [PATCH] fix HIPQUAD macro in kernel.h, Harald Welte
Indexes:	[Date] [Thread] [Top] [All Lists]