netdev
[Top] [All Lists]

Re: [PATCH] new net device feature: shared-ipv6-cards

To: AHERRMAN@xxxxxxxxxx (Andreas Herrmann)
Subject: Re: [PATCH] new net device feature: shared-ipv6-cards
From: kuznet@xxxxxxxxxxxxx
Date: Wed, 21 Aug 2002 19:55:32 +0400 (MSD)
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx, pekkas@xxxxxxxxxx
In-reply-to: <OF6E059725.5F49923C-ONC1256C1C.0054532B@de.ibm.com> from "Andreas Herrmann" at Aug 21, 2 05:28:52 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> I removed the config option, added documentation to
> Documentation/networking/netdevices.txt
> and created a new patch for the new net device feature.

One thought: if you have to add a new field to struct netdevice,
it makes lots of sense to move further and to add special method
dev->generate_eui64() instead, which will be initialized
to standard eth_generate_eui64() for normal ethernets
and to something private for your device.

In this way we are guaranteed not to have problems of this kind
in future.

Alexey


<Prev in Thread] Current Thread [Next in Thread>