Re: gred_dump (2.4.17): bad semantic and memory leak

[Martin Devera <devik@xxxxxx>]

> It does have some state. Note it will continue to work even if half
> configured just using default parameters ..
> How about totaly removing that check? It would report accumulated state
> just fine ... i.e
 
> 
> --- sch_gred.c  2002/01/19 20:05:59     1.2
> +++ sch_gred.c  2002/01/19 20:09:05
> @@ -518,10 +518,6 @@
> 
>         memset(opt, 0, (sizeof(struct tc_gred_qopt))*table->DPs);
> 
> -       if (!table->initd) {
> -               DPRINTK("NO GRED Queues setup!\n");
> -               goto rtattr_failure;
> -       }

It would solve it just cleanly.
Another possibility would be to remove goto rtattr_failure; only
and left printk here to report the mistake to an user. 

devik