netdev
[Top] [All Lists]

Re: [BUG/FIXED !] Equal Cost Multipath Broken in 2.4.x

To: bert hubert <ahu@xxxxxxx>
Subject: Re: [BUG/FIXED !] Equal Cost Multipath Broken in 2.4.x
From: Julian Anastasov <ja@xxxxxx>
Date: Thu, 20 Dec 2001 16:10:11 +0200 (EET)
Cc: <kuznet@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20011220145332.A15230@xxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
        Hello,

On Thu, 20 Dec 2001, bert hubert wrote:

> must have not been awake this morning. It does apply now, AND fixes the
> problem. Thanks!

        Very good

> > [010803]
> >  * If "dev" is not specified in multipath route, ifindex remained
> >    uninitialized. Grr. Thanks to Kunihiro Ishiguro <kunihiro@xxxxxxxxx>.
>
> I do specify dev on the commandline, however, you are right in that is the
> compiler that fixes the behaviour. Apparently, gcc-3.0 is lucky in this
> respect.

        Yes, it seems dev is an old problem. IMO the right fix is to
memset with 0 the struct before usage. This will avoid any further errors.

> I happened to be compiling with gcc-3.0 at the time, while debian compile
> their packages with gcc-2.95. I'll mention this patch on the LARTC
> mailinglist too.

        Yes, it must depend somehow on the compiler, may be from
previous calls of other functions, no time to investigate.

> Will you push this patch towards Alexey?

        If he is not reading the whole thread, please, do it directly.

> Regards,
>
> bert

Regards

--
Julian Anastasov <ja@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>