netdev
[Top] [All Lists]

Re: fib/netdev cleanup

To: ja@xxxxxx (Julian Anastasov)
Subject: Re: fib/netdev cleanup
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 18 Dec 2001 21:57:19 +0300 (MSK)
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxx
In-reply-to: <Pine.LNX.4.33.0112150030390.1240-100000@xxxxxxxxxxxx> from "Julian Anastasov" at Dec 15, 1 01:00:41 am
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> 1. fib_inetaddr_event deletes all routes when the last address is
> deleted which is wrong,

When the last address is deleted, IP is disabled on the device,
and it is pretty strange to say about some routes after this they
have no object to refer to.


> 2. FIB never detects NETDEV_UNREGISTER because ip_ptr is already NULL

See above.


> 3. We better to clear nh->nh_dev on NETDEV_UNREGISTER, fatal for
> multipath routes in 2.4 (problem known from some time ago)

Oh, damn, I forgot about this our finding. 

Are you sure that the last chunk is enough to fix this?

Alexey

<Prev in Thread] Current Thread [Next in Thread>