[Top] [All Lists]

Re: [RFC] cleaning up struct sock

To: davem@xxxxxxxxxx (David S. Miller)
Subject: Re: [RFC] cleaning up struct sock
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 11 Dec 2001 22:19:51 +0300 (MSK)
Cc: netdev@xxxxxxxxxxx, acme@xxxxxxxxxxxxxxxx, steve@xxxxxxxxxxxxxx
In-reply-to: <20011211.034755.74751257.davem@xxxxxxxxxx> from "David S. Miller" at Dec 11, 1 05:49:15 pm
Sender: owner-netdev@xxxxxxxxxxx

>      a) struct inode
>      b) struct socket

(A bit out of topic) The last is just absent now, by the way.
The information inlined into private part of inode is wrong anyway
and causes lots of troubles, starting from problems with async
signaling and finishing with identd returning wrong answers
about socket owners.

If the plan of VFS is getting rid of private part, we just should
kill struct socket. If no such plans exist, we could return to the
question of ability to get/put inodes on softirqs and move some junk
from sock to inode.

>      c) struct sock (minus per protocol areas)
>      d) struct my_protocol (whatever the socket actually is)

... which is exactly current situation.

Listen, the situation is very clear really. Reality is TCP/IP.
The only thing which could justify getting rid of padding each socket
to tcp size would be a protocol, which has status different of marginal
ans requires massive allocations like tcp. I do not see any signs of this
on horizont. Do you see?


<Prev in Thread] Current Thread [Next in Thread>