[Top] [All Lists]

Re: [PATCH] net/ipv4/*, net/core/neighbour.c jiffies cleanup

To: davem@xxxxxxxxxx (David S. Miller)
Subject: Re: [PATCH] net/ipv4/*, net/core/neighbour.c jiffies cleanup
From: kuznet@xxxxxxxxxxxxx
Date: Thu, 8 Nov 2001 20:54:29 +0300 (MSK)
Cc: tim@xxxxxxxxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxxxxxxxxx, andrewm@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxx, adilger@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, ak@xxxxxx
In-reply-to: <20011107.160950.57890584.davem@xxxxxxxxxx> from "David S. Miller" at Nov 7, 1 04:09:50 pm
Sender: owner-netdev@xxxxxxxxxxx

>    jiffies cleanup patch of the day follows. Mostly boring changes of jiffies
>    comparisons to use time_{before,after} in order to handle jiffies
>    wraparound correctly.

I want to _ask_ one thing people working on these changes.
_Please_, defer this edit to 2.5. The changes are very good,
but time for them is very bad.

When I wrote this code the macros did not exist. However, this code is right,
take my word. Hence, it is pure maintanance problem and as soon as
main reader of this code is me, I would be glad to see the changes,
but only having no deadlines.

Anyway, if someone want to try to define jiffies as somewhat
different of "unsigned long", all code needs real checking rather
than syntax changes.


<Prev in Thread] Current Thread [Next in Thread>