netdev
[Top] [All Lists]

Re: [PATCH] net/ipv4/*, net/core/neighbour.c jiffies cleanup

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] net/ipv4/*, net/core/neighbour.c jiffies cleanup
From: Tim Schmielau <tim@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 8 Nov 2001 02:20:02 +0100 (CET)
Cc: <adilger@xxxxxxxxxxxxx>, <jgarzik@xxxxxxxxxxxxxxxx>, <andrewm@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <torvalds@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <ak@xxxxxx>, <kuznet@xxxxxxxxxxxxx>
In-reply-to: <20011107.170940.10246156.davem@xxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
>
>    --- linux-2.4.14/net/ipv4/ipconfig.c       Wed Oct 31 00:08:12 2001
>    +++ linux-2.4.14-jiffies64/net/ipv4/ipconfig.c     Wed Nov  7 23:28:47 2001
>
> These cases are indeed buggy.  I'd rather fix these ones with
> time_{after,before}() though.  And again, your "signed" casts
> are totally superfluous.
>

They actually are necessary as unsigned values can never become less than
zero.

Tim


<Prev in Thread] Current Thread [Next in Thread>