| To: | mkprice@xxxxxxxxxx (Mark Price) |
|---|---|
| Subject: | Re: patch - SNMP Kernel Counters |
| From: | kuznet@xxxxxxxxxxxxx |
| Date: | Fri, 5 Oct 2001 19:25:06 +0400 (MSK DST) |
| Cc: | netdev@xxxxxxxxxxx, davem@xxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.33.0110031457150.11908-100000@xxxxxxxxxxxxxxxxxxxxx> from "Mark Price" at Oct 3, 1 03:02:05 pm |
| Sender: | owner-netdev@xxxxxxxxxxx |
Hello! Great. > o Added support for TcpRtoMin,TcpRtoMax,TcpRtoAlgorithm and TcpMaxConn > variables, including a rather ugly cludge to proc.c for TCPMaxConn. OK. > o Modified the way IpInDelivers is incremented. OK. Technically wrong though. Please try to invent some way to eliminate additional variable "aflg" in some way yet... Also: > + IP_INC_STATS_BH(IpInDiscards); > goto drop; It is pretty evident that increment must follow the label "drop". No? Well, this happens in several places. Alexey |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5, Robert Olsson |
|---|---|
| Next by Date: | Re: patch - SNMP Kernel Counters, kuznet |
| Previous by Thread: | Re: patch - SNMP Kernel Counters, kuznet |
| Next by Thread: | Re: patch - SNMP Kernel Counters, Mark Price |
| Indexes: | [Date] [Thread] [Top] [All Lists] |