| To: | samudrala@xxxxxxxxxx (Sridhar Samudrala) |
|---|---|
| Subject: | Re: [PATCH] fixes the type of 'index' in struct open_request |
| From: | kuznet@xxxxxxxxxxxxx |
| Date: | Fri, 7 Sep 2001 21:49:34 +0400 (MSK DST) |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.21.0109061627330.996-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx> from "Sridhar Samudrala" at Sep 7, 1 04:15:00 am |
| Sender: | owner-netdev@xxxxxxxxxxx |
Hello! > Looks like this field is only set, but not being read anywhere within TCP > currently, Yes, it was used only in some tests with timing out by calendar rather then scanning hash table. > probably the reason why it was not noticed till now. No, I remember this. It is an explicit padding now, though initialization should be deleted yet. > field to get the syntable hash bucket index of the openreq instead of > recalculating the hash. Is this really necessary? Not a big deal, of course, but it adds another 4 bytes and it is really useless. To _find_ an open request you need to calculate hash function... Alexey |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: notion of a local address [was: Re: ioctl SIOCGIFNETMASK: ip, kuznet |
|---|---|
| Next by Date: | Re: [PATCH] fixes the type of 'index' in struct open_request, Sridhar Samudrala |
| Previous by Thread: | [PATCH] fixes the type of 'index' in struct open_request, Sridhar Samudrala |
| Next by Thread: | Re: [PATCH] fixes the type of 'index' in struct open_request, Sridhar Samudrala |
| Indexes: | [Date] [Thread] [Top] [All Lists] |