netdev
[Top] [All Lists]

Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19
From: Matthias Andree <matthias.andree@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Sep 2001 23:19:11 +0200
Cc: kuznet@xxxxxxxxxxxxx, tao@xxxxxxxxxx, matthias.andree@xxxxxx, alan@xxxxxxxxxxxxxxxxxxx, wietse@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20010910224002.31693@colin.muc.de>
Mail-followup-to: Andi Kleen <ak@xxxxxx>, kuznet@xxxxxxxxxxxxx, tao@xxxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, wietse@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <20010910100537.W26627@khan.acc.umu.se> <200109101936.XAA00707@ms2.inr.ac.ru> <20010910224002.31693@colin.muc.de>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.3.22.1i
Andi Kleen schrieb am Montag, den 10. September 2001:

> > So that applications will have to worry about compatibility with older
> > kernels in any case.
> 
> Just hope then that no ifconfig or other binary has a two on the stack
> when calling this.

Thanks for asking, however, nothing bad will happen if there are no
4.4BSD-style aliases. If there are, you have no business using ifconfig
anyways, and ifconfig certainly has not configured the aliases (it
overwrites the primary address unless you use a separate name such as
eth0:0).

Actually, in net-tools-1.56, ifconfig does write AF_INET onto its ifr
(it gets shot otherwise), without clearing the address field (which
contains the txqueuelen result). However, the worst thing that can
happen is that ifconfig displays one of the aliases - but the alias
would match the txqueuelen then. How many people have 0.0.0.* or *.0.0.0
addresses configured as alias? Not too many. None, to be precise.

It will not bite portable applications either since those init their
address properly.

-- 
Matthias Andree

<Prev in Thread] Current Thread [Next in Thread>