netdev
[Top] [All Lists]

[PATCH] Re: [PATCH] global icmp rate limiting

To: Harald Welte <laforge@xxxxxxxxxxxx>
Subject: [PATCH] Re: [PATCH] global icmp rate limiting
From: clemens <therapy@xxxxxxxxxxxxx>
Date: Sun, 5 Aug 2001 22:22:52 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20010802162214.O1612@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20010803134206.A653@xxxxxxxxxxxxxxxxxxxxx> <20010802162214.O1612@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.3.18i
On Thu, Aug 02, 2001 at 04:22:15PM -0300, Harald Welte wrote:

> > this patch introduces global icmp rate limiting
> > (/proc/sys/net/ipv4/icmp_ratelimit) with the ability to arbitary
> > rate limit or unlimit certain icmp types (/proc/sys/net/ipv4/icmp_ratemask,
> > but you better have a look at icmp.c before changing this).
>
> If somebody is going to change the icmp rate limiting code, please take
> into consideration fixing the kernel/userspace interface as well.

you're absolutly right. 
please consider patch attached.

unit for icmp_ratelimit will be [packets/second].
HZ multiplication is cached in icmpv4_xrlim_allow.

networking code maintainers please take note of this patch. i haven't got any
response by official maintainers.

clemens

Attachment: icmp-global-rate3.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>