Re: ERRATA Re: [PATCH] fix for netfilter/nat/pppoe crashes (hopefully)

[kuznet@xxxxxxxxxxxxx]

Hello!

> Now, if Marc is seeing this, and noone can find a flaw in my logic,
> then I'd say that someone else is mangling a packet without doing (see
> ipip.c):
> 
>               nf_conntrack_put(skb->nfct);
>               skb->nfct = NULL;
> 
> Please find them and hit them hard...

Good spot. I try to force people to copy this code from tunnels,
but they prefer to copy from loopback. It is just shorter. :-)

BTW what's about loopback? It does not! Is nfct fpassed through loopback
used in some way? If it is not, it is better to add this there.

Alexey