netdev
[Top] [All Lists]

Re: missing icmp errors for udp packets

To: therapy@xxxxxxxxxxxxx (clemens)
Subject: Re: missing icmp errors for udp packets
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 31 Jul 2001 23:04:06 +0400 (MSK DST)
Cc: pekkas@xxxxxxxxxx, therapy@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, davem@xxxxxxxxxx
In-reply-to: <20010731205101.B8211@xxxxxxxxxxxxxxxxxxxxx> from "clemens" at Jul 31, 1 08:51:01 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> your patch will not prevent the first ping to empty the token bucket,
> because burst is still 0, which is larger than dst->rate_token, and since
> XRLIM_BURST_FACTOR times the timeout (which is 6*0=0 in that case) is the
> token maximum, it will be truncated to 0,
> causing the following packets (if in time) to be dropped.

Argh... I see, gap is too short and not enough of tokens are accumulated.
Thank you.

Damn, I see two ways: 1. to make sysctl active function
and recalculate max/sum of rates over classes and fill bucket.

Or to remove limiting distinguishing types, which is ideal
logically.

Alexey

<Prev in Thread] Current Thread [Next in Thread>