netdev
[Top] [All Lists]

Re: [PATCH] skb_{over,under}_panic optimizations

To: Ben LaHaise <bcrl@xxxxxxxxxx>
Subject: Re: [PATCH] skb_{over,under}_panic optimizations
From: Andi Kleen <ak@xxxxxx>
Date: Mon, 16 Jul 2001 15:11:03 +0200
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.33.0107152228490.16774-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>; from bcrl@xxxxxxxxxx on Mon, Jul 16, 2001 at 04:37:03AM +0200
References: <Pine.LNX.4.33.0107152228490.16774-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
On Mon, Jul 16, 2001 at 04:37:03AM +0200, Ben LaHaise wrote:
> Hello Dave & all,
> 
> Below is a patch that moves the skb_{over,under}_panic function calls in
> skb_put and skb_push out of line on i386 and hopefully improves register
> allocation.  If this turns out to be useful, there are bunch of other
> places we can move these kinds useful debugging assertions out of line.
> Comments?

How ugly. Does this really make any benchmarkable difference?
(very much doubting it)

If you really care about such microoptimization just use __builtin_expect.



-Andi

<Prev in Thread] Current Thread [Next in Thread>