Re: Oops in arp_rcv, patch

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxx>]

In article <20010704164654.B3805@xxxxxxxxxxxxxxxxxxxxxxxx> (at Wed, 4 Jul 2001 
16:46:54 +0200), Jacek Konieczny <jajcus@xxxxxxx> says:

>  --- it was neigh_release() function which failed. Everywhere else in
> the code its argument is protected against being NULL, but not in the
> one place. Here is my patch:
> ===== cut ====
> --- linux/net/ipv4/arp.c.orig Thu Jun 28 17:29:10 2001
> +++ linux/net/ipv4/arp.c      Tue Jul  3 19:37:25 2001
> @@ -738,7 +738,7 @@
>                           (addr_type == RTN_UNICAST  && rt->u.dst.dev != dev 
> &&
>                            (IN_DEV_PROXY_ARP(in_dev) || 
> pneigh_lookup(&arp_tbl, &tip, dev, 0)))) {
>                               n = neigh_event_ns(&arp_tbl, sha, &sip, dev);
> -                             neigh_release(n);
> +                             if (n) neigh_release(n);
>  
>                               if (skb->stamp.tv_sec == 0 ||
>                                   skb->pkt_type == PACKET_HOST ||

linux-2.4.x (0-test1 to 6) kernels are ok.

--
yoshfuji