netdev
[Top] [All Lists]

Re: net driver directory moves for 2.5

To: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Subject: Re: net driver directory moves for 2.5
From: Jes Sorensen <jes@xxxxxxxxxx>
Date: 24 Jun 2001 16:18:14 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: Jeff Garzik's message of "Fri, 22 Jun 2001 14:01:52 -0400"
References: <3B32D0FA.9451D3AA@xxxxxxxxxxxxxxxx> <d3bsngbq3b.fsf@xxxxxxxxxxxxxxxxx> <3B338810.C39CA0CE@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Gnus/5.070096 (Pterodactyl Gnus v0.96) Emacs/20.4
>>>>> "Jeff" == Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx> writes:

Jeff> Jes Sorensen wrote:
>>  Where do Lance ISA drivers go? It seems like a somewhat random
>> choice of groups to me, ie. 8390, tulip & Lance directories kinda
>> match but ISA and 3Com are orthogonal to this.

Jeff> It's not a random choice of groups at all, it's where common
Jeff> code will get grouped together the most.

Jeff> Drivers that fit into 8390, tulip, or lance categories will go
Jeff> into those directories.  Which would include a lance ISA driver.
Jeff> After that, you still have a ton of ISA and 3com drivers left
Jeff> over which are not often used.  Thus, the isa and 3com
Jeff> subdirectories.

I still think you should be consistent and stick to chip specific
directories. Some of those ISA drivers support both ISA, EISA and PCI
cards, some fall into multiple categories as mentioned
earlier. Sticking to drivers/net/<chip>/ solves a lot of the problem
and keeps it a lot cleaner IMHO.

Jes

<Prev in Thread] Current Thread [Next in Thread>