netdev
[Top] [All Lists]

Re: multicast hash incorrect on big endian archs

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: multicast hash incorrect on big endian archs
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 3 Jun 2001 19:24:18 -0700 (PDT)
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <3B1A9558.2DBAECE7@xxxxxxxxxxxxxxxx>
References: <3B1A9558.2DBAECE7@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Manfred Spraul writes:
 > I noticed that the multicast hash calculations assumed little endian
 > byte ordering in the winbond-840 driver, and it seems that several other
 > drivers are also affected:
 > 
 > 8139too, epic100, fealnx, pci-skeleton, sis900, starfile, sundance,
 > via-rhine, yellowfin
 > perhaps drivers/net/pcmcia/xircom_tulip_cb

Many big-endian systems already need to provide little-endian bitops,
for ext2's sake for example.

We should formalize this, with {set,clear,change,test}_le_bit which
technically every port has implemented in some for or another already.

Later,
David S. Miller
davem@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>