netdev
[Top] [All Lists]

Re: user's wishlist on ipv6 module

To: Andi Kleen <ak@xxxxxx>
Subject: Re: user's wishlist on ipv6 module
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Fri, 22 Jun 2001 01:08:55 +1200
Cc: Pekka Savola <pekkas@xxxxxxxxxx>, uaca@xxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20010621145248.33287@colin.muc.de>; from ak@muc.de on Thu, Jun 21, 2001 at 02:52:48PM +0200
References: <20010621142706.A13233@pusa.informat.uv.es> <Pine.LNX.4.33.0106211546350.11078-100000@netcore.fi> <20010621145248.33287@colin.muc.de>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Thu, Jun 21, 2001 at 02:52:48PM +0200, Andi Kleen wrote:

    Most modules use standardized APIs that are always available. I
    agree with the original poster that CONFIG_IPV6_MODULE should not
    be needed. The code it covers is not very big anyways, so it
    could be just made default.

Are changes other than netsyms.c required?

I'm not sure I would suggest this right now, we may aswell
rationalize netsyms.c during 2.5.x (which Alan may be thinking of
starting soon).




  --cw



--- current/net/netsyms.c~      Sun Jun 17 23:18:59 2001
+++ current/net/netsyms.c       Fri Jun 22 01:05:45 2001
@@ -55,7 +55,6 @@
 
 extern struct net_proto_family inet_family_ops;
 
-#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE) || defined 
(CONFIG_KHTTPD) || defined (CONFIG_KHTTPD_MODULE)
 #include <linux/in6.h>
 #include <linux/icmpv6.h>
 #include <net/ipv6.h>
@@ -65,7 +64,6 @@
 extern int sysctl_local_port_range[2];
 extern int tcp_port_rover;
 extern int udp_port_rover;
-#endif
 
 #endif
 
@@ -277,7 +275,7 @@
 EXPORT_SYMBOL(ipv6_addr_type);
 EXPORT_SYMBOL(icmpv6_send);
 #endif
-#if defined (CONFIG_IPV6_MODULE) || defined (CONFIG_KHTTPD) || defined 
(CONFIG_KHTTPD_MODULE)
+
 /* inet functions common to v4 and v6 */
 EXPORT_SYMBOL(inet_stream_ops);
 EXPORT_SYMBOL(inet_release);
@@ -385,12 +383,8 @@
 EXPORT_SYMBOL(sysctl_max_syn_backlog);
 #endif
 
-#if defined (CONFIG_IPV6_MODULE)
 EXPORT_SYMBOL(secure_tcpv6_sequence_number);
 EXPORT_SYMBOL(secure_ipv6_id);
-#endif
-
-#endif
 
 #ifdef CONFIG_NETLINK
 EXPORT_SYMBOL(netlink_set_err);
@@ -425,7 +419,7 @@
 EXPORT_SYMBOL(rtnl_lock);
 EXPORT_SYMBOL(rtnl_unlock);
 
-                  
+
 /* Used by at least ipip.c.  */
 EXPORT_SYMBOL(ipv4_config);
 EXPORT_SYMBOL(dev_open);

<Prev in Thread] Current Thread [Next in Thread>