netdev
[Top] [All Lists]

Re: Q: (ab)using zerocopy for drivers with alignment contraints

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: Q: (ab)using zerocopy for drivers with alignment contraints
From: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Date: Sun, 10 Jun 2001 12:56:15 -0400
Cc: netdev@xxxxxxxxxxx
Organization: MandrakeSoft
References: <3B238B31.38F6D3ED@colorfullife.com>
Sender: owner-netdev@xxxxxxxxxxx
Manfred Spraul wrote:
> 
> Several cheap busmaster nics only accept tx buffers that are 32-bit
> aligned.
> 
> Currently they memcpy into transfer buffers. What about replacing that
> memcpy with csum_copy_partial_nocheck and enabling NETIF_F_{SG,HW_CSUM}?
> 
> I've attached a beta patch against the 8139too driver.
> 
> szc_copy_csum() isn't driver specific, perhaps move it to
> linux/net/core/skbuff.c?

I'm definitely for reducing copies, so this patch looks nice.

I would prefer to call it "single-copy" or something other than
zero-copy, though...

-- 
Jeff Garzik      | Andre the Giant has a posse.
Building 1024    |
MandrakeSoft     |

<Prev in Thread] Current Thread [Next in Thread>