netdev
[Top] [All Lists]

Re: PATCH: IPv6 ndisc.c: rfc fixes, net_ratelimit(), typos

To: Pekka Savola <pekkas@xxxxxxxxxx>
Subject: Re: PATCH: IPv6 ndisc.c: rfc fixes, net_ratelimit(), typos
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 5 May 2001 16:38:58 -0700 (PDT)
Cc: <netdev@xxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.33.0105051940260.21104-300000@xxxxxxxxxx>
References: <Pine.LNX.4.33.0105051940260.21104-300000@xxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Pekka Savola writes:
 > Attached are two patches against ~2.4.4 net/ipv6/ndisc.c.  First is a real
 > patch, the second is just commentary based on top of the first one.  It
 > documents a few MUST RFC-incompliances (feel free to check/fix! :-) I came
 > across in the whereabouts they could be dealt with.  I'll continue
 > checking against that RFC in two weeks when I have more time.

I've applied your patch, thanks.  Two issues, one minor:

1) Please make patches relative to the top-level tree, this makes
   my work a lot easier and Linus prefers patches in this format too.
   Ie. if your tree is at /usr/src/linux make your patch while
   /usr/src is your cwd.

2) A lot things we are printing warning messages for ought to
   eventually just be statistic counter increments.  For example,
   the short neighbour messages etc.

   For now, I'll leave this as it might help debug things if the
   kernel complains into logs.

Later,
David S. Miller
davem@xxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>