netdev
[Top] [All Lists]

Re: IPv6: Incoming RA source-address may be non- link-local

To: Pekka Savola <pekkas@xxxxxxxxxx>
Subject: Re: IPv6: Incoming RA source-address may be non- link-local
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 3 May 2001 17:26:02 -0700 (PDT)
Cc: <netdev@xxxxxxxxxxx>, <usagi-users@xxxxxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.33.0105031339460.13399-100000@netcore.fi>
References: <Pine.LNX.4.33.0105021312080.28386-100000@netcore.fi> <Pine.LNX.4.33.0105031339460.13399-100000@netcore.fi>
Sender: owner-netdev@xxxxxxxxxxx
Pekka Savola writes:
 > On Wed, 2 May 2001, Pekka Savola wrote:
 > > In net/ipv6/ndisc,  ndisc_router_discovery function, where IPv6 router
 > > advertisements are being processed, there is no check that RA is coming
 > > from link-local address.
 > 
 > The following patch (note! untested!) should do it.  Copied with small
 > modification to the printk from ndisc_redirect_rcv:
 > 
 > --- ndisc.c~ Mon Apr 30 12:12:44 2001
 > +++ ndisc.c  Thu May  3 13:32:37 2001
 > @@ -587,6 +587,11 @@

I would really like to see these kernel messages properly
net_ratelimit()'d.  Once you test this patch for proper functionalty,
could you net_ratelimit() the printk's in this file as well and send
me the updated patch?

Thanks.

Later,
David S. Miller
davem@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>