netdev
[Top] [All Lists]

Re: [PATCH] Minor bug.

To: rusty@xxxxxxxxxxxxxxx (Rusty Russell)
Subject: Re: [PATCH] Minor bug.
From: kuznet@xxxxxxxxxxxxx
Date: Wed, 14 Mar 2001 22:40:14 +0300 (MSK)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <m14d8rK-001PJpC@mozart> from "Rusty Russell" at Mar 14, 1 02:15:01 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> skb will not crash the machine, but maybe one day it will.

It will not. Safe access to tail octets is critical for parsing
and allows to avoids lots of useless tests (sort of this one), so that
we are not going to lose this property.


> Just reading the code while on holidays...

BTW you read wrong code. This place does not exist in this form more.
New variant is more sensitive (and, hence, more paranoid) to such things.

Alexey

<Prev in Thread] Current Thread [Next in Thread>