netdev
[Top] [All Lists]

Re: [PATCH] SO_ORIGINAL_DST and sockaddr_in

To: horape@xxxxxxxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] SO_ORIGINAL_DST and sockaddr_in
From: Rusty Russell <rusty@xxxxxxxxxxxxxxxx>
Date: Thu, 22 Feb 2001 17:42:32 +1100
Cc: Harald Welte <laforge@xxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: Your message of "Thu, 22 Feb 2001 01:41:41 -0300." <20010222014141.A7501@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
In message <20010222014141.A7501@xxxxxxxxxxxxxxxxxxxxxxxxxx> you write:
> > I feel the point of that argument is to indicate the size of the
> > buffer.  We have a chance to catch coding errors; I feel the
> > getsockname/getpeername approach is wrong (truncate results if too
> > short, don't care if too long).  Unless someone can come up with a
> > compelling reason, why change?
> 
> About truncating, i think like you, but for longer than needed it's
> ok to don't care and set namelen, because how is else the user know
> how big it is beforehand? (ie, different PF == different lens)

If you don't know what PF the socket is, how do you interpret the
result?

Rusty.
--
Premature optmztion is rt of all evl. --DK

<Prev in Thread] Current Thread [Next in Thread>