skb_linearize needs fixing?

[Rusty Russell <rusty@xxxxxxxxxxxxxxxx>]

At the moment netfilter does a skb_linearize(), and the ip_queue_xmit2
dereferences skb->sk.  Boom (thanks Anton).

skb_linearize is different from skb_copy: it should copy the sk, list
and the destructor(?) (ie. be an identical copy).  I'd also prefer it to
return an int, and not free the old skb on failure (ie. int
skb_linearize(struct sk_buff **pskb)).

Oh, and inlining it seems, um, questionable.

Want a patch?
Rusty.
--
Hacking time.