netdev
[Top] [All Lists]

Re: BUG in tcp.c ?

To: eis@xxxxxxxxxxxxx (Henner Eisen)
Subject: Re: BUG in tcp.c ?
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 10 Oct 2000 19:01:11 +0400 (MSK DST)
Cc: riel@xxxxxxxxxxxxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <oud7h9kc6b.fsf@xxxxxxxxxxxxx> from "Henner Eisen" at Oct 9, 0 10:11:08 pm
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> sock_alloc_send_skb() into a function callable from bh context.
> However, just resetting sk->allocation is not sufficient.

No doubts. It is exaclty, which I wanted to say.


> In order to make sock_alloc_send_skb() non-blocking under any circumstances,
> it was also necessary to set so->sndtimeo to 0. (sock_alloc_send_skb()
> will never enter sock_wait_for_wmem() if timeo is 0).

Sorry? This thing is called O_NONBLOCK. sndtimeo is additional baroque
detail, which is not used provided you do not touch it. Do not touch it.


> nbd.c does not play the latter trick.

Nobody needs to play such tricks.


What's about calling from interrupts (not the case with nbd),
no tricks will help. It is simply impossible to use top level
syscall from interrupt.

Alexey

<Prev in Thread] Current Thread [Next in Thread>