netdev
[Top] [All Lists]

Re: PATCH 2.4.0.9.2: export ethtool interface

To: ak@xxxxxx
Subject: Re: PATCH 2.4.0.9.2: export ethtool interface
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 21 Sep 2000 05:23:25 -0700
Cc: andrewm@xxxxxxxxxx, becker@xxxxxxxxx, havanna_moon@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20000921143042.A3635@xxxxxxxxxxx> (message from Andi Kleen on Thu, 21 Sep 2000 14:30:42 +0200)
References: <39C883CF.9FB262FC@xxxxxxxxxx> <Pine.LNX.4.10.10009201152510.1031-100000@xxxxxxxxxxxxx> <39C9F123.D8FA4F68@xxxxxxxxxx> <20000921133302.36264@xxxxxxxxxxxx> <200009211159.EAA09358@xxxxxxxxxxxxxxx> <20000921143042.A3635@xxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
   Date: Thu, 21 Sep 2000 14:30:42 +0200
   From: Andi Kleen <ak@xxxxxx>

   Also I would propose to run dev->do_ioctl and probably other device
   methods inside the BKL, they are not performance critical anyways
   and it is much safer.

Why, that's really dumb.

All of net/* and drivers/net/* runs %100 asynchronous and threaded on
SMP systems.  Your suggested change would create a new exception :-)

The only exception being "stupid" protocols which are:

1) wrapped by a global spinlock in softint processing
2) wrapped with lock_kernel()/unlock_kernel() around socket method
   entry points

Later,
David S. Miller
davem@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>