[ switched mailing lists ]
John Newbigin wrote:
>
> I have examined the bonding code and found a few things which seem to
> improve the stability.
>
> in bond_close, as each device is removed, queue->num_slaves in
> incremented, this should be decremented.
>
> After the loop I set queue->head & queue->tail to NULL. I don't know if
> the queue gets reused but if it does it will need these set to NULL.
>
> It would be good it someone could confirm these changes.
>
> John.
Kernel 2.2, I assume?
The queue->num_slaves fix has already made it into 2.2.17-pre14.
I agree that queue->head should be zeroed in bond_close(). Otherwise bad
things will happen in bond_enslave() next time the binding device is opened
and bonded to. May as well zero queue->tail as well.
|