netdev
[Top] [All Lists]

Re: modular net drivers, take 2

To: Andi Kleen <ak@xxxxxx>
Subject: Re: modular net drivers, take 2
From: Andrew Morton <andrewm@xxxxxxxxxx>
Date: Tue, 20 Jun 2000 22:06:58 +1000
Cc: Keith Owens <kaos@xxxxxxxxxx>, Donald Becker <becker@xxxxxxxxx>, "netdev@xxxxxxxxxxx" <netdev@xxxxxxxxxxx>
References: <Pine.LNX.4.10.10006192011230.26261-100000@vaio.greennet> <3292.961460999@kao2.melbourne.sgi.com> <20000620124146.A1375@fred.muc.de>, <20000620124146.A1375@fred.muc.de>; from Andi Kleen on Tue, Jun 20, 2000 at 12:41:46PM +0200 <20000620124613.A1833@fred.muc.de>
Sender: owner-netdev@xxxxxxxxxxx
Andi Kleen wrote:
> 
> 
> Ok, there is still a small race with the actual module unload. I think
> the cleanest solution is to let open/close run in the big kernel lock.
> They are not performance critical anyways.
> 
> Comments ?

- devinet_ioctl() calls dev_change_flags() direct, thus
  neatly bypassing your lock_kernel() :(

- sys_ioctl() and sys_delete_module() both already claim
  the big lock, so where's the race anyway?  I feel I'm missing
  something..

<Prev in Thread] Current Thread [Next in Thread>