Re: [timers] net/sched/*

[kuznet@xxxxxxxxxxxxx]

Hello!

> +/* REVIEWME: called from process context */

It is not essential. It is static timer.


> +/*
> + * REVIEWME: Called from process context.  I think del_timer_sync is safe 
> here
> + */
> +     del_timer_async(&q->wd_timer);
> +     del_timer_async(&q->delay_timer);

Alas. It is called under spinlock and cannot be synchronous.

This and all the rest must use (existing) reference counts.

It will be cleaned later, this code needs some cleaning in any case.

Alexey