Re: Tx queueing

[Andrey Savochkin <saw@xxxxxxxxxxxxx>]

Hello,

On Sun, May 21, 2000 at 09:08:35PM -0400, Jeff Garzik wrote:
> I was referring to PCI drivers, not PCI hardware.  What I meant was that
> my experience has shown that some of the early softnet conversions
> (example 'A') caused transmit timeouts quite easily, until updated to
> look like example B.
> 
> Example A:
> 
>       drv_start_xmit() {
>               netif_stop_queue()
>               /* queue packet for xmit */
>               if (!tx_full)
>                       netif_start_queue()
>       }
>       interrupt() {
>               /* Tx'd a packet */
>               if (tx_full)
>                       netif_stop_queue()
>               else
>                       netif_wake_queue()
>       }

I don't see what's wrong with A.

Best regards
                Andrey