Andrew Morton wrote:
> Jeff Garzik wrote:
> > Which [drivers have wrong softnet logic]? They need fixing..
> 3c50?.c. Probably others...
> I'm disinclined to change these:
> - They're slow anyway.
> - Increased possiblity of breaking them
> - Broken 2.2/kcompat24 compatibility
I should note that drivers with the logic in question (start_xmit:
stop... start if not full) caused transmit timeouts and other nasties
when used in modern PCI drivers. That's why I consider such logic a
bug, not just a correctness or performance issue.
> - No performance tweaks for [E]ISA drivers in 2.3.
> - Correctness fixes if they're obvious.
> - If the SMP-safety fixes are not obvious, mark the driver as UP-only.
> Sound sensible?
* highly agree with the first
* and the second
* I think we should go through drivers and mark them SMP-safe... :)
Jeff Garzik | Liberty is always dangerous, but
Building 1024 | it is the safest thing we have.
MandrakeSoft, Inc. | -- Harry Emerson Fosdick