netdev
[Top] [All Lists]

Re: [PATCH] Move shaper control information into skb->cb

To: almesber@xxxxxxxxxxx (Werner Almesberger)
Subject: Re: [PATCH] Move shaper control information into skb->cb
From: kuznet@xxxxxxxxxxxxx
Date: Tue, 25 Apr 2000 18:48:13 +0400 (MSK DST)
Cc: ak@xxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200004250145.DAA11544@xxxxxxxxxxxxxxxx> from "Werner Almesberger" at Apr 25, 0 03:45:24 am
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> Some ATM drivers use it, e.g. see at the end of drivers/atm/eni.h

They will not correlate. In fact, cb can be consideerd invalid when it
intersects dev->hard_start_xmit(). So that both shaper and any other device
may use it as they desire, provided they do not assume anything about
its content on entry.

BTW, Werner, it is exaclty why I objected against putting
skb->tc_index to cb.

BTW#2, qdiscs sort of sch_atm could use cb to pass some tags,
but in this case they are supposed to have a private entry
to corresponding device, and should guarantee that this tag
will not be used occasionally on packet, not passed though sch_atm.

Alexey

<Prev in Thread] Current Thread [Next in Thread>