On Tue, Dec 28, 1999 at 08:33:05AM +0100, Rusty Russell wrote:
> Hi all,
>
> This allows random parties to grab a field in the skbuff
> header, and attach a destructor. This makes the connection tracking
> code (a netfilter module) much nicer (ie. real reference counts), and
> can also be used for other things where you need to play with skbs.
> It is the scalable replacement for the icky `mark' field which
> everyone hated (well, I hated, anyway).
>
> What do the networking triumvirate think? (Or should that be
> `networking troika'?)
Ugh. It is a ugly duck, but I guess it is needed.
It adds at least one cache line access in the hot path.
Please use a flag bit in the common part at least, that can be tested
without fetching the new cache line on destruction (so that hot path
code without firewalling does not pay the price)
Also the linked list is cache unfriendly. Because the reserve buffer
is limited anyways I think it is ok to use a fixed size array for the
destructor pointers.
-Andi
|