netdev
[Top] [All Lists]

Re: Oops - bug in IPv6 code

To: Andrew Morton <morton@xxxxxxxxxxxxxxxxxx>
Subject: Re: Oops - bug in IPv6 code
From: Artur Frysiak <wiget@xxxxxxxxxxxxxxxxxx>
Date: Sat, 27 Nov 1999 13:51:21 +0100
Cc: venaas <venaas@xxxxxxxxxxx>, Netdev list <netdev@xxxxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, "David S . Miller" <davem@xxxxxxxxxx>, Pedro Roque <roque@xxxxxxxxxxx>, Linux Kernel List <linux-kernel@xxxxxxxxxxxxxxxx>
In-reply-to: <383FC97A.A5074285@xxxxxxxxxxxxxxxxxxxxx>; from morton@xxxxxxxxxxxxxxxxxx on Sat, Nov 27, 1999 at 12:07:22PM +0000
Mail-followup-to: Andrew Morton <morton@xxxxxxxxxxxxxxxxxx>, venaas <venaas@xxxxxxxxxxx>, Netdev list <netdev@xxxxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, "David S . Miller" <davem@xxxxxxxxxx>, Pedro Roque <roque@xxxxxxxxxxx>, Linux Kernel List <linux-kernel@xxxxxxxxxxxxxxxx>
References: <19991127103026.A6725@wiget> <19991127111632.A18674@xxxxxxxxxxx> <383FC97A.A5074285@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: Artur Frysiak <wiget@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
On Sat, 27 Nov 1999, Andrew Morton wrote:

> venaas wrote:
> >                 if (dst == NULL) {
> >                         struct flowi fl;
> > -                       struct dst_entry *dst;
> 
> Compilation with -Wshadow would have caught this.
> 
> Any reason why this is not done?

I apply this patch and kernel work fine. If I get any other oops I mail info
about this to netdev.

Wiget
-- 
  __    __ _            _
 / / /\ \ (_) __ _  ___| |_  @__mail:  Artur Frysiak
 \ \/  \/ / |/ _` |/ _ \ __|            Rudlice 10
  \  /\  /| | (_| |  __/ |_           98-311 Ostrowek
   \/  \/ |_|\__, |\___|\__|
             |___/           email:   Wiget@xxxxxxxxxxxxxxxxxx
PGP key: http://www.t17.ds.pwr.wroc.pl/~wiget/pgp.key
1024D/12FE7FAE ACB5 5834 C2F7 F86E 4F21  6D88 06B8 2CFE 12FE 7FAE

<Prev in Thread] Current Thread [Next in Thread>