From owner-xfs@oss.sgi.com Thu Feb 1 11:15:29 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:15:34 -0800 (PST) X-Spam-oss-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JFSqw012562 for ; Thu, 1 Feb 2007 11:15:29 -0800 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11Ihjnc80914784; Thu, 1 Feb 2007 10:43:45 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11JEWmm3433507; Thu, 1 Feb 2007 13:14:32 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 7BDE11F71F6; Thu, 1 Feb 2007 13:14:32 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 956828 - xfsqa test failures when quota and gquota options are used Message-Id: <20070201191432.7BDE11F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:14:32 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10516 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 496 Lines: 15 Log a message for each quota file restored, not just the first one. Date: Thu Feb 1 11:13:53 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: dgc The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220674a xfsdump/restore/content.c - 1.47 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/restore/content.c.diff?r1=text&tr1=1.47&r2=text&tr2=1.46&f=h From owner-xfs@oss.sgi.com Thu Feb 1 11:17:46 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:17:54 -0800 (PST) X-Spam-oss-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JHjqw013262 for ; Thu, 1 Feb 2007 11:17:45 -0800 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11Ik2nc80914831; Thu, 1 Feb 2007 10:46:02 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11JGnmm3419281; Thu, 1 Feb 2007 13:16:49 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 858641F71F6; Thu, 1 Feb 2007 13:16:49 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 959172 - check file size at dump time rather than only during initial scan Message-Id: <20070201191649.858641F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:16:49 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10517 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 1019 Lines: 22 When using -z, check a file's size against the max dump file size just before dumping the file, rather than only during the initial scan. Date: Thu Feb 1 11:16:27 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: bnaujok The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220675a xfsdump/dump/content.c - 1.45 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/dump/content.c.diff?r1=text&tr1=1.45&r2=text&tr2=1.44&f=h xfsdump/dump/inomap.c - 1.32 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/dump/inomap.c.diff?r1=text&tr1=1.32&r2=text&tr2=1.31&f=h xfsdump/common/hsmapi.c - 1.6 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/hsmapi.c.diff?r1=text&tr1=1.6&r2=text&tr2=1.5&f=h xfsdump/common/hsmapi.h - 1.5 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/hsmapi.h.diff?r1=text&tr1=1.5&r2=text&tr2=1.4&f=h From owner-xfs@oss.sgi.com Thu Feb 1 11:20:15 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:20:19 -0800 (PST) X-Spam-oss-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JKBqw014071 for ; Thu, 1 Feb 2007 11:20:14 -0800 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l11J3dDW023876 for ; Thu, 1 Feb 2007 13:03:39 -0600 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11IWmnc80912386; Thu, 1 Feb 2007 10:32:48 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11J3amm3430598; Thu, 1 Feb 2007 13:03:36 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 171991F71F6; Thu, 1 Feb 2007 13:03:35 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 959167 - xfsdump uses getopt's optopt variable incorrectly Message-Id: <20070201190336.171991F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:03:35 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10519 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 1909 Lines: 35 xfsdump uses the optopt variable from getopt incorrectly. It assumes that the value is set to the current option being processed, when in fact it is only set when getopt encounters an unknown option. Thanks to Kouta Ooizumi. Date: Thu Feb 1 11:02:45 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: bnaujok The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220672a xfsdump/dump/content.c - 1.44 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/dump/content.c.diff?r1=text&tr1=1.44&r2=text&tr2=1.43&f=h xfsdump/restore/content.c - 1.46 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/restore/content.c.diff?r1=text&tr1=1.46&r2=text&tr2=1.45&f=h xfsdump/common/global.c - 1.12 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/global.c.diff?r1=text&tr1=1.12&r2=text&tr2=1.11&f=h xfsdump/common/drive.c - 1.13 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/drive.c.diff?r1=text&tr1=1.13&r2=text&tr2=1.12&f=h xfsdump/common/mlog.c - 1.16 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/mlog.c.diff?r1=text&tr1=1.16&r2=text&tr2=1.15&f=h xfsdump/common/media.c - 1.9 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/media.c.diff?r1=text&tr1=1.9&r2=text&tr2=1.8&f=h xfsdump/common/drive_scsitape.c - 1.19 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/drive_scsitape.c.diff?r1=text&tr1=1.19&r2=text&tr2=1.18&f=h xfsdump/common/drive_minrmt.c - 1.17 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/drive_minrmt.c.diff?r1=text&tr1=1.17&r2=text&tr2=1.16&f=h xfsdump/common/main.c - 1.32 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/main.c.diff?r1=text&tr1=1.32&r2=text&tr2=1.31&f=h From owner-xfs@oss.sgi.com Thu Feb 1 11:20:11 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:20:18 -0800 (PST) X-Spam-oss-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JKAqw014062 for ; Thu, 1 Feb 2007 11:20:11 -0800 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l11JCJDW025224 for ; Thu, 1 Feb 2007 13:12:19 -0600 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11IfTnc80910120; Thu, 1 Feb 2007 10:41:29 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11JCHmm3428418; Thu, 1 Feb 2007 13:12:17 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 42CE61F71F6; Thu, 1 Feb 2007 13:12:17 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 959168 - xfsdump's logging facility not initialized early enough Message-Id: <20070201191217.42CE61F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:12:17 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10518 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 968 Lines: 22 Initialize xfsdump's logging facility earlier during initialization. Thanks to Kouta Ooizumi. Date: Thu Feb 1 11:10:50 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: dgc The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220673a xfsdump/common/stream.c - 1.13 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/stream.c.diff?r1=text&tr1=1.13&r2=text&tr2=1.12&f=h xfsdump/common/mlog.h - 1.9 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/mlog.h.diff?r1=text&tr1=1.9&r2=text&tr2=1.8&f=h xfsdump/common/mlog.c - 1.17 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/mlog.c.diff?r1=text&tr1=1.17&r2=text&tr2=1.16&f=h xfsdump/common/main.c - 1.33 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/common/main.c.diff?r1=text&tr1=1.33&r2=text&tr2=1.32&f=h From owner-xfs@oss.sgi.com Thu Feb 1 11:25:54 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:26:02 -0800 (PST) X-Spam-oss-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JPrqw015772 for ; Thu, 1 Feb 2007 11:25:54 -0800 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11Is9nc80921770; Thu, 1 Feb 2007 10:54:10 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11JOvmm3431964; Thu, 1 Feb 2007 13:24:57 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 8A1D61F71F6; Thu, 1 Feb 2007 13:24:57 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 960742 - bump xfsdump version to 2.2.44 Message-Id: <20070201192457.8A1D61F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:24:57 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10520 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 608 Lines: 17 Bump xfsdump version to 2.2.44 and document changes. Date: Thu Feb 1 11:24:34 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: kfr The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220677a xfsdump/VERSION - 1.85 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/VERSION.diff?r1=text&tr1=1.85&r2=text&tr2=1.84&f=h xfsdump/doc/CHANGES - 1.99 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/doc/CHANGES.diff?r1=text&tr1=1.99&r2=text&tr2=1.98&f=h From owner-xfs@oss.sgi.com Thu Feb 1 11:35:12 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 11:35:20 -0800 (PST) X-Spam-oss-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l11JZBqw017261 for ; Thu, 1 Feb 2007 11:35:12 -0800 Received: from imr2.americas.sgi.com (imr2.americas.sgi.com [198.149.16.18]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l11JLADW026591 for ; Thu, 1 Feb 2007 13:21:10 -0600 Received: from poppy-e236.americas.sgi.com (poppy-e236.americas.sgi.com [128.162.236.207]) by imr2.americas.sgi.com (8.12.9/8.12.10/SGI_generic_relay-1.2) with ESMTP id l11IoLnc80919886; Thu, 1 Feb 2007 10:50:21 -0800 (PST) Received: from attica.americas.sgi.com (attica.americas.sgi.com [128.162.236.44]) by poppy-e236.americas.sgi.com (8.12.9/ASC-news-1.4) with ESMTP id l11JL9mm3431856; Thu, 1 Feb 2007 13:21:09 -0600 (CST) Received: by attica.americas.sgi.com (Postfix, from userid 2022) id 13F9F1F71F6; Thu, 1 Feb 2007 13:21:09 -0600 (CST) To: xfs-dev@sgi.com, xfs@sgi.com, sgi.bugs.xfs@sgi.com Subject: TAKE 960730 - incremental xfsdump can skip modified/new files Message-Id: <20070201192109.13F9F1F71F6@attica.americas.sgi.com> Date: Thu, 1 Feb 2007 13:21:09 -0600 (CST) From: wkendall@sgi.com (Bill Kendall) X-archive-position: 10521 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wkendall@sgi.com Precedence: bulk X-list: xfs Content-Length: 710 Lines: 19 Issue a sync call before doing the initial inode scan so that any inode changes in the inode cache are reflected in the bulk stat calls. This is necessary for incremental dumps to work properly (i.e. not skip files) so that all inodes changed before the dump time are included in the dump. Date: Thu Feb 1 11:20:37 PST 2007 Workarea: attica.americas.sgi.com:/data/lwork/attica1/dmfgrp/4.0_chroot/wkendall/xfs-cmds Inspected by: kfr The following file(s) were checked into: bonnie.engr.sgi.com:/isms/xfs-cmds/master Modid: master:xfs-cmds:220676a xfsdump/dump/inomap.c - 1.33 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfsdump/dump/inomap.c.diff?r1=text&tr1=1.33&r2=text&tr2=1.32&f=h From owner-xfs@oss.sgi.com Thu Feb 1 21:24:16 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 21:24:21 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l125OCqw006015 for ; Thu, 1 Feb 2007 21:24:14 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id QAA02793; Fri, 2 Feb 2007 16:23:11 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 4DD7758FF653; Fri, 2 Feb 2007 16:23:11 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: PARTIAL TAKE 959267 - bad clientid during log replay of snapshot image Message-Id: <20070202052311.4DD7758FF653@chook.melbourne.sgi.com> Date: Fri, 2 Feb 2007 16:23:11 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10530 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 2285 Lines: 50 Ensure a frozen filesystem has a clean log before writing the dummy record. The current Linux XFS freeze code is a mess. We flush the metadata buffers out while we are still allowing new transactions to start and then fail to flush the dirty buffers back out before writing the unmount and dummy records to the log. This leads to problems when the frozen filesystem is used for snapshots - we do log recovery on a readonly image and often it appears that the log image in the snapshot is not correct. Hence we end up with hangs, oops and mount failures when trying to mount a snapshot image that has been created when the filesystem has not been correctly frozen. To fix this, we need to move th metadata flush to after we wait for all current transactions to complete in teh second stage of the freeze. This means that when we write the final log records, the log should be clean and recovery should never occur on a snapshot image created from a frozen filesystem. Date: Fri Feb 2 16:22:20 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: donaldd The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28010a fs/xfs/xfs_vfsops.c - 1.514 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vfsops.c.diff?r1=text&tr1=1.514&r2=text&tr2=1.513&f=h - Push xfs_quiesce_fs() down into xfs_freeze() so it occurs after we've blocked new transactions and waited for all the currently running transactions to complete. hence we should have a clean log before we write the unmount and dummy records into the log. fs/xfs/linux-2.6/xfs_vfs.h - 1.68 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vfs.h.diff?r1=text&tr1=1.68&r2=text&tr2=1.67&f=h - Add definition of SYNC_DIO_WAIT for telling the sync code to wait for direct I/O to complete. fs/xfs/linux-2.6/xfs_super.c - 1.376 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.376&r2=text&tr2=1.375&f=h - After the writes are frozen, simply flush out the data and wait for all data I/O (including direct I/O) to complete. Don't bother flushing the metadata out - we still have active transactions at this point. From owner-xfs@oss.sgi.com Thu Feb 1 21:33:52 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 21:33:56 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l125Xmqw007348 for ; Thu, 1 Feb 2007 21:33:50 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id QAA03079; Fri, 2 Feb 2007 16:32:48 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 94D5658FF653; Fri, 2 Feb 2007 16:32:48 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960408 - dmapi bulkstat returns incorrect number of blocks used Message-Id: <20070202053248.94D5658FF653@chook.melbourne.sgi.com> Date: Fri, 2 Feb 2007 16:32:48 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10531 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 606 Lines: 20 DMAPI bulkstat block count units incorrect. Return dt_blocks in units of 512 byte blocks instead of filesystem blocks. Date: Fri Feb 2 16:32:12 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: vapo The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28011a fs/xfs/dmapi/xfs_dm.c - 1.32 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/dmapi/xfs_dm.c.diff?r1=text&tr1=1.32&r2=text&tr2=1.31&f=h - Return dt_blocks in units of 512 byte blocks instead of filesystem blocks. From owner-xfs@oss.sgi.com Thu Feb 1 21:41:50 2007 Received: with ECARTIS (v1.0.0; list xfs); Thu, 01 Feb 2007 21:41:53 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00, J_CHICKENPOX_36 autolearn=no version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l125fkqw008631 for ; Thu, 1 Feb 2007 21:41:49 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id QAA03219; Fri, 2 Feb 2007 16:40:47 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l125ek7Y110583035; Fri, 2 Feb 2007 16:40:46 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l125ei80110563597; Fri, 2 Feb 2007 16:40:44 +1100 (AEDT) Date: Fri, 2 Feb 2007 16:40:44 +1100 From: David Chinner To: xfs-dev@sgi.com Cc: xfs@oss.sgi.com Subject: Review: Don't use kmap() in xfs_iozero(). Message-ID: <20070202054044.GO33919298@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i X-archive-position: 10532 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 1451 Lines: 58 kmap is inefficient and does scale well. kmap_atomic() is a better choice. Use the generic wrapper function instead of open coding the kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton. Comments? Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group --- fs/xfs/linux-2.6/xfs_lrw.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_lrw.c 2007-01-31 13:56:12.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c 2007-01-31 14:19:50.379179841 +1100 @@ -138,7 +138,6 @@ xfs_iozero( unsigned bytes; struct page *page; struct address_space *mapping; - char *kaddr; int status; mapping = ip->i_mapping; @@ -156,15 +155,13 @@ xfs_iozero( if (!page) break; - kaddr = kmap(page); status = mapping->a_ops->prepare_write(NULL, page, offset, offset + bytes); - if (status) { + if (status) goto unlock; - } - memset((void *) (kaddr + offset), 0, bytes); - flush_dcache_page(page); + memclear_highpage_flush(page, (unsigned int)offset, bytes); + status = mapping->a_ops->commit_write(NULL, page, offset, offset + bytes); if (!status) { @@ -175,7 +172,6 @@ xfs_iozero( } unlock: - kunmap(page); unlock_page(page); page_cache_release(page); if (status) From owner-xfs@oss.sgi.com Fri Feb 2 04:24:34 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 04:24:40 -0800 (PST) X-Spam-oss-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l12COWqw007203 for ; Fri, 2 Feb 2007 04:24:33 -0800 Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1HCws3-00069l-Tu; Fri, 02 Feb 2007 11:46:23 +0000 Date: Fri, 2 Feb 2007 11:46:23 +0000 From: Christoph Hellwig To: David Chinner Cc: xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: freezing sometimes leaves the log dirty Message-ID: <20070202114623.GA23187@infradead.org> References: <20070130220326.GM33919298@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070130220326.GM33919298@melbourne.sgi.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-archive-position: 10533 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Content-Length: 2539 Lines: 78 On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote: > - if (unlikely(sb->s_frozen == SB_FREEZE_WRITE)) > - flags = SYNC_QUIESCE; > - else > + if (unlikely(sb->s_frozen == SB_FREEZE_WRITE)) { > + /* > + * First stage of freeze - no more writers will make progress > + * now we are here, so we flush delwri and delalloc buffers > + * here, then wait for all I/O to complete. Data is frozen at > + * that point. Metadata is not frozen, transactions can still > + * occur here so don't bother flushing the buftarg (i.e > + * SYNC_QUIESCE) because it'll just get dirty again. > + */ > + flags = SYNC_FSDATA | SYNC_DELWRI | SYNC_WAIT | SYNC_DIO_WAIT; > + } else You remove all uses of SYNC_QUIESCE in this patch, so please kill the definition aswell. > + * SYNC_DIO_WAIT - The caller wants us to wait for all direct I/Os > + * as well to ensure all data I/O completes before we > + * return. Forms the drain side of the write barrier needed > + * to safely quiesce the filesystem. > * > */ > /*ARGSUSED*/ > @@ -892,10 +896,7 @@ xfs_sync( > { > xfs_mount_t *mp = XFS_BHVTOM(bdp); > > - if (unlikely(flags == SYNC_QUIESCE)) > - return xfs_quiesce_fs(mp); > - else > - return xfs_syncsub(mp, flags, NULL); > + return xfs_syncsub(mp, flags, NULL); > } > > /* > @@ -1181,6 +1182,12 @@ xfs_sync_inodes( > } > > } > + /* > + * When freezing, we need to wait ensure direct I/O is complete > + * as well to ensure all data modification is complete here > + */ > + if (flags & SYNC_DIO_WAIT) > + vn_iowait(vp); vn_iowait waits for v_iocount decrementing to zero. We use v_iocount for tracking ioend structures that are used both for buffered and direct I/O. Because of that the flag should probably be SYNC_IOWAIT and the comment updated to reflect this. > +/* > + * Second stage of a freeze. The data is already frozen, now we have to take > + * care of the metadata. New transactions are already blocked, so we need to > + * wait for any remaining transactions to drain out before proceding. > + */ > STATIC void > xfs_freeze( > bhv_desc_t *bdp) > { > xfs_mount_t *mp = XFS_BHVTOM(bdp); > > + /* wait for all modifications to complete */ > while (atomic_read(&mp->m_active_trans) > 0) > delay(100); > > + /* flush inodes and push all remaining buffers out to disk */ > + xfs_quiesce_fs(mp); > + > + BUG_ON(atomic_read(&mp->m_active_trans) > 0); > + xfs_vfsops.c is considered common code, so you should probably use ASSERT here, not BUG_ON. From owner-xfs@oss.sgi.com Fri Feb 2 04:24:49 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 04:25:21 -0800 (PST) X-Spam-oss-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_20, J_CHICKENPOX_36 autolearn=no version=3.2.0-pre1-r497472 Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l12COlqw007246 for ; Fri, 2 Feb 2007 04:24:48 -0800 Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1HCwu6-0006Ce-EX; Fri, 02 Feb 2007 11:48:30 +0000 Date: Fri, 2 Feb 2007 11:48:30 +0000 From: Christoph Hellwig To: David Chinner Cc: xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: Don't use kmap() in xfs_iozero(). Message-ID: <20070202114830.GB23187@infradead.org> References: <20070202054044.GO33919298@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070202054044.GO33919298@melbourne.sgi.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-archive-position: 10534 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Content-Length: 495 Lines: 14 On Fri, Feb 02, 2007 at 04:40:44PM +1100, David Chinner wrote: > kmap is inefficient and does scale well. kmap_atomic() is a better > choice. Use the generic wrapper function instead of open coding the > kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton. > > Comments? Looks good. > + memclear_highpage_flush(page, (unsigned int)offset, bytes); Do you need the cast here? An unsigned long should be automatically demoted to an unsigned int when passing it as an argument. From owner-xfs@oss.sgi.com Fri Feb 2 05:40:48 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 05:40:55 -0800 (PST) X-Spam-oss-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_20, J_CHICKENPOX_36 autolearn=no version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l12Degqw017508 for ; Fri, 2 Feb 2007 05:40:44 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id AAA14594; Sat, 3 Feb 2007 00:39:43 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l12Ddg7Y111988747; Sat, 3 Feb 2007 00:39:42 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l12DdfwH111900500; Sat, 3 Feb 2007 00:39:41 +1100 (AEDT) Date: Sat, 3 Feb 2007 00:39:41 +1100 From: David Chinner To: Christoph Hellwig Cc: David Chinner , xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: Don't use kmap() in xfs_iozero(). Message-ID: <20070202133941.GW33919298@melbourne.sgi.com> References: <20070202054044.GO33919298@melbourne.sgi.com> <20070202114830.GB23187@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070202114830.GB23187@infradead.org> User-Agent: Mutt/1.4.2.1i X-archive-position: 10535 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 863 Lines: 27 On Fri, Feb 02, 2007 at 11:48:30AM +0000, Christoph Hellwig wrote: > On Fri, Feb 02, 2007 at 04:40:44PM +1100, David Chinner wrote: > > kmap is inefficient and does scale well. kmap_atomic() is a better > > choice. Use the generic wrapper function instead of open coding the > > kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton. > > > > Comments? > > Looks good. > > > + memclear_highpage_flush(page, (unsigned int)offset, bytes); > > Do you need the cast here? An unsigned long should be automatically > demoted to an unsigned int when passing it as an argument. Even on 64 bit platforms? I just added an explicit cast as a matter of avoiding potential gcc warnings on other platforms/compiler versions. Maybe I'm just being paranoid and I can remove it? Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group From owner-xfs@oss.sgi.com Fri Feb 2 06:08:10 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 06:08:17 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l12E86qw020622 for ; Fri, 2 Feb 2007 06:08:08 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id BAA15252; Sat, 3 Feb 2007 01:07:08 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l12E777Y112086427; Sat, 3 Feb 2007 01:07:07 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l12E76FB112045480; Sat, 3 Feb 2007 01:07:06 +1100 (AEDT) Date: Sat, 3 Feb 2007 01:07:06 +1100 From: David Chinner To: Christoph Hellwig Cc: David Chinner , xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: freezing sometimes leaves the log dirty Message-ID: <20070202140706.GX33919298@melbourne.sgi.com> References: <20070130220326.GM33919298@melbourne.sgi.com> <20070202114623.GA23187@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070202114623.GA23187@infradead.org> User-Agent: Mutt/1.4.2.1i X-archive-position: 10536 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 7989 Lines: 193 On Fri, Feb 02, 2007 at 11:46:23AM +0000, Christoph Hellwig wrote: > On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote: > > - if (unlikely(sb->s_frozen == SB_FREEZE_WRITE)) > > - flags = SYNC_QUIESCE; > > - else > > + if (unlikely(sb->s_frozen == SB_FREEZE_WRITE)) { > > + /* > > + * First stage of freeze - no more writers will make progress > > + * now we are here, so we flush delwri and delalloc buffers > > + * here, then wait for all I/O to complete. Data is frozen at > > + * that point. Metadata is not frozen, transactions can still > > + * occur here so don't bother flushing the buftarg (i.e > > + * SYNC_QUIESCE) because it'll just get dirty again. > > + */ > > + flags = SYNC_FSDATA | SYNC_DELWRI | SYNC_WAIT | SYNC_DIO_WAIT; > > + } else > > You remove all uses of SYNC_QUIESCE in this patch, so please kill the > definition aswell. Yup, didn't think of that. > > + /* > > + * When freezing, we need to wait ensure direct I/O is complete > > + * as well to ensure all data modification is complete here > > + */ > > + if (flags & SYNC_DIO_WAIT) > > + vn_iowait(vp); > > vn_iowait waits for v_iocount decrementing to zero. We use v_iocount > for tracking ioend structures that are used both for buffered and direct > I/O. Because of that the flag should probably be SYNC_IOWAIT and the comment > updated to reflect this. Ok, that's probably a better reflection of what the code does. We've already waited for all buffered I/O via the SYNC_WAIT flag, so I was only really thinking about the direct I/o case here. > > +/* > > + * Second stage of a freeze. The data is already frozen, now we have to take > > + * care of the metadata. New transactions are already blocked, so we need to > > + * wait for any remaining transactions to drain out before proceding. > > + */ > > STATIC void > > xfs_freeze( > > bhv_desc_t *bdp) > > { > > xfs_mount_t *mp = XFS_BHVTOM(bdp); > > > > + /* wait for all modifications to complete */ > > while (atomic_read(&mp->m_active_trans) > 0) > > delay(100); > > > > + /* flush inodes and push all remaining buffers out to disk */ > > + xfs_quiesce_fs(mp); > > + > > + BUG_ON(atomic_read(&mp->m_active_trans) > 0); > > + > > xfs_vfsops.c is considered common code, so you should probably use > ASSERT here, not BUG_ON. good catch. Patch below cleans all this up and also fixes the 2.4 tree as well. BTW, i think further cleanup in xfs_quiesce_fs() can be done - that flush loop looks redundant - neither Irix nor 2.4 linux need it, and I can't see why it would be needed on 2.6. It looks to me like it was trying to fix the problem I'm fixing right now. I'll look into it further at some point... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group --- fs/xfs/linux-2.4/xfs_super.c | 8 +++----- fs/xfs/linux-2.4/xfs_vfs.h | 2 +- fs/xfs/linux-2.6/xfs_super.c | 2 +- fs/xfs/linux-2.6/xfs_vfs.h | 3 +-- fs/xfs/xfs_vfsops.c | 17 +++++++++-------- 5 files changed, 15 insertions(+), 17 deletions(-) Index: 2.6.x-xfs-new/fs/xfs/linux-2.4/xfs_super.c =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.4/xfs_super.c 2007-02-02 16:35:36.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/linux-2.4/xfs_super.c 2007-02-03 00:59:00.453115972 +1100 @@ -669,13 +669,11 @@ struct super_block *freeze_bdev(struct b wmb(); /* Flush the refcache */ - bhv_vfs_sync(vfsp, SYNC_REFCACHE | SYNC_WAIT, NULL);; + bhv_vfs_sync(vfsp, SYNC_REFCACHE | SYNC_WAIT, NULL); /* Flush delalloc and delwri data */ - bhv_vfs_sync(vfsp, SYNC_DELWRI | SYNC_WAIT, NULL);; - - /* Flush out everything to it's normal place */ - bhv_vfs_sync(vfsp, SYNC_QUIESCE, NULL); + bhv_vfs_sync(vfsp, + SYNC_FSDATA|SYNC_DELWRI|SYNC_WAIT|SYNC_IOWAIT, NULL); /* Pause transaction subsystem */ vfsp->vfs_frozen = SB_FREEZE_TRANS; Index: 2.6.x-xfs-new/fs/xfs/linux-2.4/xfs_vfs.h =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.4/xfs_vfs.h 2007-01-16 10:54:15.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/linux-2.4/xfs_vfs.h 2007-02-03 00:51:38.255434540 +1100 @@ -92,7 +92,7 @@ typedef enum { #define SYNC_FSDATA 0x0020 /* flush fs data (e.g. superblocks) */ #define SYNC_REFCACHE 0x0040 /* prune some of the nfs ref cache */ #define SYNC_REMOUNT 0x0080 /* remount readonly, no dummy LRs */ -#define SYNC_QUIESCE 0x0100 /* quiesce fileystem for a snapshot */ +#define SYNC_IOWAIT 0x0100 /* wait for all I/O to complete */ #define SHUTDOWN_META_IO_ERROR 0x0001 /* write attempt to metadata failed */ #define SHUTDOWN_LOG_IO_ERROR 0x0002 /* write attempt to the log failed */ Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_super.c =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_super.c 2007-02-02 16:35:36.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_super.c 2007-02-03 00:59:03.236749054 +1100 @@ -674,7 +674,7 @@ xfs_fs_sync_super( * occur here so don't bother flushing the buftarg (i.e * SYNC_QUIESCE) because it'll just get dirty again. */ - flags = SYNC_FSDATA | SYNC_DELWRI | SYNC_WAIT | SYNC_DIO_WAIT; + flags = SYNC_FSDATA | SYNC_DELWRI | SYNC_WAIT | SYNC_IOWAIT; } else flags = SYNC_FSDATA | (wait ? SYNC_WAIT : 0); Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_vfs.h =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_vfs.h 2007-02-02 16:35:02.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_vfs.h 2007-02-03 00:51:41.638988060 +1100 @@ -91,8 +91,7 @@ typedef enum { #define SYNC_FSDATA 0x0020 /* flush fs data (e.g. superblocks) */ #define SYNC_REFCACHE 0x0040 /* prune some of the nfs ref cache */ #define SYNC_REMOUNT 0x0080 /* remount readonly, no dummy LRs */ -#define SYNC_QUIESCE 0x0100 /* quiesce fileystem for a snapshot */ -#define SYNC_DIO_WAIT 0x0200 /* wait for direct I/O to complete */ +#define SYNC_IOWAIT 0x0100 /* wait for all I/O to complete */ #define SHUTDOWN_META_IO_ERROR 0x0001 /* write attempt to metadata failed */ #define SHUTDOWN_LOG_IO_ERROR 0x0002 /* write attempt to the log failed */ Index: 2.6.x-xfs-new/fs/xfs/xfs_vfsops.c =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/xfs_vfsops.c 2007-02-02 16:35:36.000000000 +1100 +++ 2.6.x-xfs-new/fs/xfs/xfs_vfsops.c 2007-02-03 00:49:10.946876638 +1100 @@ -881,10 +881,10 @@ xfs_statvfs( * this by simply making sure the log gets flushed * if SYNC_BDFLUSH is set, and by actually writing it * out otherwise. - * SYNC_DIO_WAIT - The caller wants us to wait for all direct I/Os - * as well to ensure all data I/O completes before we - * return. Forms the drain side of the write barrier needed - * to safely quiesce the filesystem. + * SYNC_IOWAIT - The caller wants us to wait for all data I/O to complete + * before we return (including direct I/O). Forms the drain + * side of the write barrier needed to safely quiesce the + * filesystem. * */ /*ARGSUSED*/ @@ -1183,10 +1183,11 @@ xfs_sync_inodes( } /* - * When freezing, we need to wait ensure direct I/O is complete - * as well to ensure all data modification is complete here + * When freezing, we need to wait ensure all I/O (including direct + * I/O) is complete to ensure no further data modification can take + * place after this point */ - if (flags & SYNC_DIO_WAIT) + if (flags & SYNC_IOWAIT) vn_iowait(vp); if (flags & SYNC_BDFLUSH) { @@ -1984,7 +1985,7 @@ xfs_freeze( /* flush inodes and push all remaining buffers out to disk */ xfs_quiesce_fs(mp); - BUG_ON(atomic_read(&mp->m_active_trans) > 0); + ASSERT(atomic_read(&mp->m_active_trans) == 0); /* Push the superblock and write an unmount record */ xfs_log_unmount_write(mp); From owner-xfs@oss.sgi.com Fri Feb 2 08:50:15 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 08:50:22 -0800 (PST) X-Spam-oss-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l12GoDqw014528 for ; Fri, 2 Feb 2007 08:50:15 -0800 Received: from omx2.sgi.com ([198.149.32.25]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l12GdxDW001507 for ; Fri, 2 Feb 2007 10:39:59 -0600 Received: from lab41.emea.sgi.com (lab41.emea.sgi.com [144.253.75.41]) by omx2.sgi.com (8.12.11/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l12GfEk6022797 for ; Fri, 2 Feb 2007 08:41:14 -0800 Received: by lab41.emea.sgi.com (Postfix, from userid 1000) id 37298576B9; Fri, 2 Feb 2007 16:57:09 +0000 (GMT) To: xfs@oss.sgi.com Subject: TAKE 960788 - Fix callers of xfs_iozero() to zero the correct range. Message-Id: <20070202165709.37298576B9@lab41.emea.sgi.com> Date: Fri, 2 Feb 2007 16:57:09 +0000 (GMT) From: lachlan@lab41.emea.sgi.com (Lachlan McIlroy) X-archive-position: 10537 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: lachlan@lab41.emea.sgi.com Precedence: bulk X-list: xfs Content-Length: 1120 Lines: 27 Fix callers of xfs_iozero() to zero the correct range. The problem is the two callers of xfs_iozero() are rounding out the range to be zeroed to the end of a fsb and in some cases this extends past the new eof. The call to commit_write() in xfs_iozero() will cause the Linux inode's file size to be set too high. Date: Sat Feb 3 03:36:02 AEDT 2007 Workarea: vpn-emea-sw-emea-160-1.emea.sgi.com:/home/lachlan/isms/2.6.x-xfs Inspected by: dgc Author: lachlan The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28013a fs/xfs/xfs_inode.c - 1.458 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.458&r2=text&tr2=1.457&f=h fs/xfs/linux-2.6/xfs_lrw.h - 1.55 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_lrw.h.diff?r1=text&tr1=1.55&r2=text&tr2=1.54&f=h fs/xfs/linux-2.6/xfs_lrw.c - 1.254 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_lrw.c.diff?r1=text&tr1=1.254&r2=text&tr2=1.253&f=h - Fix callers of xfs_iozero() to zero the correct range. From owner-xfs@oss.sgi.com Fri Feb 2 10:07:13 2007 Received: with ECARTIS (v1.0.0; list xfs); Fri, 02 Feb 2007 10:07:18 -0800 (PST) X-Spam-oss-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l12I79qw026205 for ; Fri, 2 Feb 2007 10:07:12 -0800 Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1HD2ne-0003kK-Iz; Fri, 02 Feb 2007 18:06:14 +0000 Date: Fri, 2 Feb 2007 18:06:14 +0000 From: Christoph Hellwig To: David Chinner Cc: Christoph Hellwig , xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: Don't use kmap() in xfs_iozero(). Message-ID: <20070202180614.GA13938@infradead.org> References: <20070202054044.GO33919298@melbourne.sgi.com> <20070202114830.GB23187@infradead.org> <20070202133941.GW33919298@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070202133941.GW33919298@melbourne.sgi.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-archive-position: 10538 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Content-Length: 420 Lines: 9 On Sat, Feb 03, 2007 at 12:39:41AM +1100, David Chinner wrote: > Even on 64 bit platforms? I just added an explicit cast as a matter > of avoiding potential gcc warnings on other platforms/compiler > versions. Maybe I'm just being paranoid and I can remove it? Yes, it's fine on 64bit platforms aswell - I just built my equivalent buffer.c changes on 64bit powerpc and we have lots of similar cases all over the tree. From owner-xfs@oss.sgi.com Sat Feb 3 10:25:12 2007 Received: with ECARTIS (v1.0.0; list xfs); Sat, 03 Feb 2007 10:25:16 -0800 (PST) X-Spam-oss-Status: No, score=0.0 required=5.0 tests=BAYES_50 autolearn=ham version=3.2.0-pre1-r497472 Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l13IPAqw009923 for ; Sat, 3 Feb 2007 10:25:11 -0800 Received: by ug-out-1314.google.com with SMTP id a2so1034036ugf for ; Sat, 03 Feb 2007 10:24:12 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=rVl4bE434eUJ7CPil5AxpkChzeGkK/bFcw8Bsa1OTsc3xN/l8tFxCmNFs5iZk1JmiW8W23Va3NOpwShC8EHyzF9WHfaS5GqCyjsPKxalAVT514i3MCVp53VLKmHPOxOBG9G6bhCHeJb0m+7BOB8mBWemcmXB3HSyumn70WGvXQY= Received: by 10.78.146.11 with SMTP id t11mr886246hud.1170525569294; Sat, 03 Feb 2007 09:59:29 -0800 (PST) Received: by 10.78.177.2 with HTTP; Sat, 3 Feb 2007 09:59:29 -0800 (PST) Message-ID: Date: Sat, 3 Feb 2007 18:59:29 +0100 From: "KE Liew" To: xfs@oss.sgi.com Subject: bad magic and dubious inode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-archive-position: 10546 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: ke.liew@gmail.com Precedence: bulk X-list: xfs Content-Length: 1993 Lines: 73 Hello, It's been a great day, and this is the situation. Files were being transfered from one hdd to another, SATA to IDE, and BANG and error occured, can't remember exactly what, but I had to umount it. Successful, and ran xfs_check ==================== eXiStEnCe:~# xfs_check -s /dev/hdb bad magic # 0 in inobt block 15/916145 ==================== Doesn't look good at all. I attempted the famous xfs_repair :) ==================== eXiStEnCe:~# xfs_repair -n /dev/hdb Phase 1 - find and verify superblock... Phase 2 - using internal log - scan filesystem freespace and inode maps... bad magic # 0 in inobt block 15/916145 dubious inode btree block header 15/916145 - found root inode chunk Phase 3 - for each AG... - scan (but don't clear) agi unlinked lists... - process known inodes and perform inode discovery... - agno = 0 - agno = 1 - agno = 2 - agno = 3 - agno = 4 - agno = 5 - agno = 6 - agno = 7 - agno = 8 - agno = 9 - agno = 10 - agno = 11 - agno = 12 - agno = 13 - agno = 14 - agno = 15 - process newly discovered inodes... Phase 4 - check for duplicate blocks... - setting up duplicate extent list... - check for inodes claiming duplicate blocks... - agno = 0 - agno = 1 - agno = 2 - agno = 3 - agno = 4 - agno = 5 - agno = 6 - agno = 7 - agno = 8 - agno = 9 - agno = 10 - agno = 11 - agno = 12 - agno = 13 - agno = 14 - agno = 15 No modify flag set, skipping phase 5 Inode allocation btrees are too corrupted, skipping phases 6 and 7 No modify flag set, skipping filesystem flush and exiting. ==================== As you can see, it's almost dead? I haven't mount it yet, so I hope it's all safe and cool. What should be the next step for me to take? Kwang From owner-xfs@oss.sgi.com Sat Feb 3 11:05:20 2007 Received: with ECARTIS (v1.0.0; list xfs); Sat, 03 Feb 2007 11:05:25 -0800 (PST) X-Spam-oss-Status: No, score=0.0 required=5.0 tests=BAYES_50 autolearn=ham version=3.2.0-pre1-r497472 Received: from serv108.segi.ulg.ac.be (serv108.segi.ulg.ac.be [139.165.32.111]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l13J5Hqw015000 for ; Sat, 3 Feb 2007 11:05:19 -0800 Received: (qmail 9766 invoked by uid 510); 3 Feb 2007 19:37:43 +0100 Received: from 139.165.123.213 by serv108.segi.ulg.ac.be (envelope-from , uid 501) with qmail-scanner-1.25 (clamdscan: 0.88.6/2517. Clear:RC:1(139.165.123.213):. Processed in 0.028574 secs); 03 Feb 2007 18:37:43 -0000 Received: from unknown (HELO ulg.ac.be) ([139.165.123.213]) (envelope-sender ) by serv108.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP for ; 3 Feb 2007 19:37:43 +0100 Received: by ulg.ac.be (nbSMTP-1.00) for uid 1000 wildcat@espix.org; Sat, 3 Feb 2007 19:37:23 +0100 (CET) Date: Sat, 3 Feb 2007 19:37:23 +0100 From: wildcat To: xfs@oss.sgi.com Subject: XFS "no space left" problem Message-ID: <20070203183723.GA1652@dunno.espix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) X-archive-position: 10547 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: wildcat@espix.org Precedence: bulk X-list: xfs Content-Length: 2308 Lines: 84 Hi dear list, I recently migrated a 1.3Tbyte partition from reiserfs to XFS. As the 1.3Tb partition was full, my idea was to shrink reiserfs partition of 100Gig at a time, and then grow the XFS one. This has been working since 1.1To for XFS partition. Now I'm in the following situation: /dev/mapper/crypt-data 1.2T 1.1T 134G 89% /jail2 dunno jail2 # touch a dunno jail2 # touch b touch: cannot touch `b': No space left on device dunno jail2 # From there if I delete 'a', I could create a file of any size. but then will be running again into the "no space left". From here, some people told me of an inodes problem, that I checked first: /dev/mapper/crypt-data 561850144 158335 561691809 1% /jail2 is outputing from df -i. umount/remount of the partition doesn't change anything. here are some information about the filesystem details: dunno jail2 # xfs_info /jail2 meta-data=/dev/crypt/data isize=256 agcount=188, agsize=1638400 blks = sectsz=512 attr=0 data = bsize=4096 blocks=306708480, imaxpct=25 = sunit=0 swidth=0 blks, unwritten=1 naming =version 2 bsize=4096 log =internal bsize=4096 blocks=12800, version=1 = sectsz=512 sunit=0 blks realtime =none extsz=65536 blocks=0, rtextents=0 dunno / # xfs_db /dev/crypt/data xfs_db> frag actual 140099, ideal 134926, fragmentation factor 3.69% xfs_db> freesp from to extents blocks pct 1 1 801 801 0.00 2 3 2 5 0.00 32 63 2 89 0.00 128 255 3 517 0.00 256 511 4 1676 0.00 512 1023 5 3776 0.01 1024 2047 7 10765 0.03 262144 524287 23 9200216 26.21 1048576 1638400 16 25888649 73.74 xfs_db> I can't think of a Fix solution from here and I'm stuck. As this box is in production and remotely managed; Go to the place, take the hard drives and backup/restore is not a solution. Any help/comment/fix/idea would be very appreciated. Any additionnal information you need could be asked :) TIA, Best regards, wildcat From owner-xfs@oss.sgi.com Sat Feb 3 15:39:34 2007 Received: with ECARTIS (v1.0.0; list xfs); Sat, 03 Feb 2007 15:39:38 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l13NdVqw029755 for ; Sat, 3 Feb 2007 15:39:33 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id KAA29087; Sun, 4 Feb 2007 10:38:31 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l13NcT7Y112748522; Sun, 4 Feb 2007 10:38:30 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l13NcS70112175756; Sun, 4 Feb 2007 10:38:28 +1100 (AEDT) Date: Sun, 4 Feb 2007 10:38:28 +1100 From: David Chinner To: wildcat Cc: xfs@oss.sgi.com Subject: Re: XFS "no space left" problem Message-ID: <20070203233828.GD44411608@melbourne.sgi.com> References: <20070203183723.GA1652@dunno.espix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20070203183723.GA1652@dunno.espix.org> User-Agent: Mutt/1.4.2.1i X-archive-position: 10548 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 2584 Lines: 72 On Sat, Feb 03, 2007 at 07:37:23PM +0100, wildcat wrote: > Hi dear list, > > > I recently migrated a 1.3Tbyte partition from reiserfs to XFS. > As the 1.3Tb partition was full, my idea was to shrink reiserfs > partition of 100Gig at a time, and then grow the XFS one. So you've filled up the lower terabyte of the partition before you added the space above 1TB. The problem is almost certainly going to be that there's no room left to allocate inodes below the 1TB mark (32 bit inode filesystem) because all that space is taken up by data.... > dunno jail2 # xfs_info /jail2 > meta-data=/dev/crypt/data isize=256 agcount=188, > agsize=1638400 blks > = sectsz=512 attr=0 > data = bsize=4096 blocks=306708480, > imaxpct=25 > = sunit=0 swidth=0 blks, unwritten=1 > naming =version 2 bsize=4096 > log =internal bsize=4096 blocks=12800, version=1 > = sectsz=512 sunit=0 blks > realtime =none extsz=65536 blocks=0, rtextents=0 > > dunno / # xfs_db /dev/crypt/data > xfs_db> frag > actual 140099, ideal 134926, fragmentation factor 3.69% > xfs_db> freesp > from to extents blocks pct > 1 1 801 801 0.00 > 2 3 2 5 0.00 > 32 63 2 89 0.00 > 128 255 3 517 0.00 > 256 511 4 1676 0.00 > 512 1023 5 3776 0.01 > 1024 2047 7 10765 0.03 > 262144 524287 23 9200216 26.21 > 1048576 1638400 16 25888649 73.74 > xfs_db> Mostly large blocks. I bet they are all in AGs above the 1TB mark. One thing you can do is look at the freespace per AG: # for ag in `seq 0 1 188`; do > echo freespace in AG $ag > xfs_db ­r -c "freesp -s -a $ag" /dev/crypt/data | grep "total free" > done And see how many of the AGs below 1TB (~6.4GB per AG, so those below about about AG 160) have no free space. To allocate new inodes you need a contiguous extent of 16k plus another 4 free blocks, so you need at _least_ 8 free blocks in an AG to allocate a new inode chunk on disk. If this is the case, then you need to delete some files to get space free below 1TB for more inodes and then copy a large file or two so they are moved above the 1TB mark, then remove the original copy to make space for inodes below 1TB. Or get a 64bit machine and use inode64. ;) HTH. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group From owner-xfs@oss.sgi.com Sat Feb 3 15:43:29 2007 Received: with ECARTIS (v1.0.0; list xfs); Sat, 03 Feb 2007 15:43:36 -0800 (PST) X-Spam-oss-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_40 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l13NhNqw030805 for ; Sat, 3 Feb 2007 15:43:28 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id KAA29133; Sun, 4 Feb 2007 10:42:23 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l13NgM7Y113492087; Sun, 4 Feb 2007 10:42:23 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l13NgLZt113244723; Sun, 4 Feb 2007 10:42:21 +1100 (AEDT) Date: Sun, 4 Feb 2007 10:42:21 +1100 From: David Chinner To: KE Liew Cc: xfs@oss.sgi.com Subject: Re: bad magic and dubious inode Message-ID: <20070203234221.GE44411608@melbourne.sgi.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-archive-position: 10549 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 1205 Lines: 44 On Sat, Feb 03, 2007 at 06:59:29PM +0100, KE Liew wrote: > Hello, > > It's been a great day, and this is the situation. Files were being > transfered from one hdd to another, SATA to IDE, and BANG and error > occured, can't remember exactly what, but I had to umount it. Can you look in your syslog for the forced shutdown messages? > Successful, and ran xfs_check > > ==================== > eXiStEnCe:~# xfs_check -s /dev/hdb > bad magic # 0 in inobt block 15/916145 > ==================== > > Doesn't look good at all. I attempted the famous xfs_repair :) You ran "xfs_repair -n" which means it didn't fix anything; it just told you about errors it found. > No modify flag set, skipping phase 5 > Inode allocation btrees are too corrupted, skipping phases 6 and 7 > No modify flag set, skipping filesystem flush and exiting. > ==================== > > As you can see, it's almost dead? No, it's not dead - xfs-repair should be able to fix the problem if you let it. > I haven't mount it yet, so I hope > it's all safe and cool. What should be the next step for me to take? run xfs_repair without the -n flag. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group From owner-xfs@oss.sgi.com Sun Feb 4 05:26:01 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 05:26:05 -0800 (PST) X-Spam-oss-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_50,RCVD_IN_PBL, SPF_HELO_PASS autolearn=no version=3.2.0-pre1-r497472 Received: from lucidpixels.com (lucidpixels.com [75.144.35.66]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l14DPwqw032356 for ; Sun, 4 Feb 2007 05:26:01 -0800 Received: by lucidpixels.com (Postfix, from userid 1001) id 5B97D1A000697; Sun, 4 Feb 2007 08:25:04 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by lucidpixels.com (Postfix) with ESMTP id 49483A050A86 for ; Sun, 4 Feb 2007 08:25:04 -0500 (EST) Date: Sun, 4 Feb 2007 08:25:04 -0500 (EST) From: Justin Piszcz X-X-Sender: jpiszcz@p34.internal.lan To: xfs@oss.sgi.com Subject: Spam on list? Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-archive-position: 10554 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: jpiszcz@lucidpixels.com Precedence: bulk X-list: xfs Content-Length: 250 Lines: 9 Who runs the XFS mailing list admin-wise? Could we add some basic anti-spam measures, I am not subscribed to many mailing lists but this one seems to generate the most spam. Any chance they'd consider switching from Sendmail -> Postfix? Justin. From owner-xfs@oss.sgi.com Sun Feb 4 10:45:07 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 10:45:12 -0800 (PST) X-Spam-oss-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50, SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l14Ij6qw013555 for ; Sun, 4 Feb 2007 10:45:07 -0800 Received: from [10.0.0.4] (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id E180018013A80; Sun, 4 Feb 2007 12:44:11 -0600 (CST) Message-ID: <45C62982.1090206@sandeen.net> Date: Sun, 04 Feb 2007 12:44:18 -0600 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Justin Piszcz CC: xfs@oss.sgi.com Subject: Re: Spam on list? References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 10555 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Content-Length: 579 Lines: 24 Justin Piszcz wrote: > Who runs the XFS mailing list admin-wise? A cabal... > Could we add some basic anti-spam measures, I am not subscribed to many > mailing lists but this one seems to generate the most spam. > > Any chance they'd consider switching from Sendmail -> Postfix? > > Justin. > > There are actually many spam measures in place... spamassassin, and others, but it seems they just can't keep up. The one spam measure that's not in place is subscriber-only posting. I think it may be time to revisit that decision. It's gotten really bad lately. -Eric From owner-xfs@oss.sgi.com Sun Feb 4 11:42:34 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 11:42:39 -0800 (PST) X-Spam-oss-Status: No, score=0.0 required=5.0 tests=BAYES_50 autolearn=ham version=3.2.0-pre1-r497472 Received: from postfix1-g20.free.fr (postfix1-g20.free.fr [212.27.60.42]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l14JgW3c020847 for ; Sun, 4 Feb 2007 11:42:33 -0800 Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28]) by postfix1-g20.free.fr (Postfix) with ESMTP id 08B288FE0E5 for ; Sun, 4 Feb 2007 20:18:11 +0100 (CET) Received: from galadriel.home (pla78-1-82-235-234-79.fbx.proxad.net [82.235.234.79]) by smtp2-g19.free.fr (Postfix) with ESMTP id C7DFC812E; Sun, 4 Feb 2007 20:18:08 +0100 (CET) Date: Sun, 4 Feb 2007 20:18:08 +0100 From: Emmanuel Florac To: Eric Sandeen Cc: Justin Piszcz , xfs@oss.sgi.com Subject: Re: Spam on list? Message-ID: <20070204201808.05240120@galadriel.home> In-Reply-To: <45C62982.1090206@sandeen.net> References: <45C62982.1090206@sandeen.net> Organization: Intellique X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by oss.sgi.com id l14JgY3c020851 X-archive-position: 10556 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: eflorac@intellique.com Precedence: bulk X-list: xfs Content-Length: 430 Lines: 14 Le Sun, 04 Feb 2007 12:44:18 -0600 vous écriviez: > The one spam measure that's not in place is subscriber-only posting. > > I think it may be time to revisit that decision. It's gotten really > bad lately. All other lists I'm following do so, and nobody complains. -- -------------------------------------------------- Emmanuel Florac www.intellique.com -------------------------------------------------- From owner-xfs@oss.sgi.com Sun Feb 4 13:47:17 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 13:47:22 -0800 (PST) X-Spam-oss-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_05, SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l14LlG3c009130 for ; Sun, 4 Feb 2007 13:47:17 -0800 Received: from [10.0.0.4] (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id 0AB0918013A89; Sun, 4 Feb 2007 15:46:22 -0600 (CST) Message-ID: <45C6542D.6060803@sandeen.net> Date: Sun, 04 Feb 2007 15:46:21 -0600 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Eric Sandeen CC: Justin Piszcz , xfs@oss.sgi.com Subject: Re: Spam on list? References: <45C62982.1090206@sandeen.net> In-Reply-To: <45C62982.1090206@sandeen.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 10557 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Content-Length: 302 Lines: 10 Eric Sandeen wrote: > There are actually many spam measures in place... spamassassin, and > others, but it seems they just can't keep up. In the meantime we added another measure today, we'll see if it helps. I know it's bad... Thanks, -Eric (not the admin per se but at least the admin-pesterer) From owner-xfs@oss.sgi.com Sun Feb 4 13:57:26 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 13:57:31 -0800 (PST) X-Spam-oss-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from postoffice.aconex.com (mail.app.aconex.com [203.89.192.138]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l14LvO3c011236 for ; Sun, 4 Feb 2007 13:57:26 -0800 Received: from edge (unknown [203.89.192.141]) by postoffice.aconex.com (Postfix) with ESMTP id CF916AAC421; Mon, 5 Feb 2007 08:42:04 +1100 (EST) Subject: Re: Review: freezing sometimes leaves the log dirty From: Nathan Scott Reply-To: nscott@aconex.com To: Christoph Hellwig Cc: David Chinner , xfs-dev@sgi.com, xfs@oss.sgi.com In-Reply-To: <20070202114623.GA23187@infradead.org> References: <20070130220326.GM33919298@melbourne.sgi.com> <20070202114623.GA23187@infradead.org> Content-Type: text/plain Organization: Aconex Date: Mon, 05 Feb 2007 08:56:55 +1100 Message-Id: <1170626215.18017.394.camel@edge> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit X-archive-position: 10558 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: nscott@aconex.com Precedence: bulk X-list: xfs Content-Length: 519 Lines: 19 On Fri, 2007-02-02 at 11:46 +0000, Christoph Hellwig wrote: > On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote: > > + /* flush inodes and push all remaining buffers out to disk */ > > + xfs_quiesce_fs(mp); > > + > > + BUG_ON(atomic_read(&mp->m_active_trans) > 0); > > + > > xfs_vfsops.c is considered common code, so you should probably use > ASSERT here, not BUG_ON. There's also an ASSERT_ALWAYS macro IIRC, if you want the equivalent functionality of BUG_ON (i.e. always check). cheers. -- Nathan From owner-xfs@oss.sgi.com Sun Feb 4 15:46:21 2007 Received: with ECARTIS (v1.0.0; list xfs); Sun, 04 Feb 2007 15:46:26 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l14NkI3c024088 for ; Sun, 4 Feb 2007 15:46:20 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id KAA27325; Mon, 5 Feb 2007 10:45:19 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id l14NjH7Y114469623; Mon, 5 Feb 2007 10:45:18 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id l14NjF53114324456; Mon, 5 Feb 2007 10:45:15 +1100 (AEDT) Date: Mon, 5 Feb 2007 10:45:15 +1100 From: David Chinner To: Nathan Scott Cc: Christoph Hellwig , David Chinner , xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: freezing sometimes leaves the log dirty Message-ID: <20070204234515.GI44411608@melbourne.sgi.com> References: <20070130220326.GM33919298@melbourne.sgi.com> <20070202114623.GA23187@infradead.org> <1170626215.18017.394.camel@edge> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1170626215.18017.394.camel@edge> User-Agent: Mutt/1.4.2.1i X-archive-position: 10559 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 716 Lines: 25 On Mon, Feb 05, 2007 at 08:56:55AM +1100, Nathan Scott wrote: > On Fri, 2007-02-02 at 11:46 +0000, Christoph Hellwig wrote: > > On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote: > > > + /* flush inodes and push all remaining buffers out to disk */ > > > + xfs_quiesce_fs(mp); > > > + > > > + BUG_ON(atomic_read(&mp->m_active_trans) > 0); > > > + > > > > xfs_vfsops.c is considered common code, so you should probably use > > ASSERT here, not BUG_ON. > > There's also an ASSERT_ALWAYS macro IIRC, if you want the equivalent > functionality of BUG_ON (i.e. always check). True, I forgot about that one. Thx, Nathan.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group From owner-xfs@oss.sgi.com Mon Feb 5 01:33:01 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 01:33:08 -0800 (PST) X-Spam-oss-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_05 autolearn=ham version=3.2.0-pre1-r497472 Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l159Wx3c030924 for ; Mon, 5 Feb 2007 01:33:00 -0800 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 092561226B; Mon, 5 Feb 2007 10:32:04 +0100 (CET) To: Eric Sandeen Cc: Justin Piszcz , xfs@oss.sgi.com Subject: Re: Spam on list? References: <45C62982.1090206@sandeen.net> From: Andi Kleen Date: 05 Feb 2007 11:32:25 +0100 In-Reply-To: <45C62982.1090206@sandeen.net> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-archive-position: 10560 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: ak@suse.de Precedence: bulk X-list: xfs Content-Length: 244 Lines: 9 Eric Sandeen writes: > > I think it may be time to revisit that decision. It's gotten really > bad lately. Please don't do that. It means nothing can be cross posted from l-k anymore, which would be pretty bad. -Andi From owner-xfs@oss.sgi.com Mon Feb 5 04:07:52 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 04:07:57 -0800 (PST) X-Spam-oss-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_20, MIME_8BIT_HEADER autolearn=no version=3.2.0-pre1-r497472 Received: from mx1.suse.de (mail.suse.de [195.135.220.2]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15C7o3c023322 for ; Mon, 5 Feb 2007 04:07:52 -0800 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 1F5A612368; Mon, 5 Feb 2007 13:06:52 +0100 (CET) From: Andi Kleen To: "Martin =?iso-8859-1?q?Schr=F6der?=" Subject: Re: Spam on list? Date: Mon, 5 Feb 2007 13:06:30 +0100 User-Agent: KMail/1.9.5 Cc: "Eric Sandeen" , "Justin Piszcz" , xfs@oss.sgi.com References: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> In-Reply-To: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200702051306.34279.ak@suse.de> X-archive-position: 10564 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: ak@suse.de Precedence: bulk X-list: xfs Content-Length: 565 Lines: 17 On Monday 05 February 2007 12:52, Martin Schröder wrote: > 05 Feb 2007 11:32:25 +0100, Andi Kleen : > > Please don't do that. It means nothing can be cross posted > > from l-k anymore, which would be pretty bad. > > Then set up a list admin who can approve such postings. That adds unacceptable latency. Also lists who spam senders with bounce messages tend to be dropped quickly from cc lists. Also you couldn't list xfs@ as bug report address anymore because bug report addresses must be available to everyone. In general it's a bad idea. -Andi From owner-xfs@oss.sgi.com Mon Feb 5 04:55:28 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 04:55:33 -0800 (PST) X-Spam-oss-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, MIME_8BIT_HEADER autolearn=no version=3.2.0-pre1-r497472 Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.239]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15CtQ3c003394 for ; Mon, 5 Feb 2007 04:55:28 -0800 Received: by wx-out-0506.google.com with SMTP id t4so1494055wxc for ; Mon, 05 Feb 2007 04:54:31 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=YR+qKonBF/aS2E56+at/QWJXAJHly2ILVW9tt23ScPA2zwj0FOSyb6nYy8Ha3DRMqyBlon8YPGnQaeHYD356+oRMO2KFAc+bKe4dnwBd6HRXGMqDcCLR0WLqcXWJP4evnniUhm7mFbJ3tBsupGzUYCu7hZwFKLofwDIA9rfwVyM= Received: by 10.90.73.3 with SMTP id v3mr8530307aga.1170676352546; Mon, 05 Feb 2007 03:52:32 -0800 (PST) Received: by 10.90.95.5 with HTTP; Mon, 5 Feb 2007 03:52:32 -0800 (PST) Message-ID: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> Date: Mon, 5 Feb 2007 12:52:32 +0100 From: "=?ISO-8859-1?Q?Martin_Schr=F6der?=" To: "Andi Kleen" Subject: Re: Spam on list? Cc: "Eric Sandeen" , "Justin Piszcz" , xfs@oss.sgi.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45C62982.1090206@sandeen.net> X-Google-Sender-Auth: a247d31bfb9666e0 X-archive-position: 10565 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: martin@oneiros.de Precedence: bulk X-list: xfs Content-Length: 235 Lines: 9 05 Feb 2007 11:32:25 +0100, Andi Kleen : > Please don't do that. It means nothing can be cross posted > from l-k anymore, which would be pretty bad. Then set up a list admin who can approve such postings. Best Martin From owner-xfs@oss.sgi.com Mon Feb 5 06:19:31 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 06:19:39 -0800 (PST) X-Spam-oss-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_40, SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15EJU3c017256 for ; Mon, 5 Feb 2007 06:19:31 -0800 Received: from [10.0.0.4] (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id 5E69C18013A89; Mon, 5 Feb 2007 08:18:35 -0600 (CST) Message-ID: <45C73CB9.5000402@sandeen.net> Date: Mon, 05 Feb 2007 08:18:33 -0600 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Andi Kleen CC: =?ISO-8859-1?Q?Martin_Schr=F6der?= , Justin Piszcz , xfs@oss.sgi.com Subject: Re: Spam on list? References: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> <200702051306.34279.ak@suse.de> In-Reply-To: <200702051306.34279.ak@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-archive-position: 10566 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Content-Length: 841 Lines: 26 Andi Kleen wrote: > On Monday 05 February 2007 12:52, Martin Schröder wrote: >> 05 Feb 2007 11:32:25 +0100, Andi Kleen : >>> Please don't do that. It means nothing can be cross posted >>> from l-k anymore, which would be pretty bad. >> Then set up a list admin who can approve such postings. > > That adds unacceptable latency. Also lists who spam senders > with bounce messages tend to be dropped quickly from cc lists. > > Also you couldn't list xfs@ as bug report address anymore because > bug report addresses must be available to everyone. > > In general it's a bad idea. > > -Andi > Well, I agree w/ those arguments too, Andi. I honestly don't know why oss seems to have so much more spam than, say, LKML. It is getting to a really bad level, and I sympathize with those whose inboxes are bombarded, too. -Eric From owner-xfs@oss.sgi.com Mon Feb 5 06:44:12 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 06:44:16 -0800 (PST) X-Spam-oss-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15EiB3c021399 for ; Mon, 5 Feb 2007 06:44:12 -0800 Received: from lab41.emea.sgi.com (lab41.emea.sgi.com [144.253.75.41]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with ESMTP id l15EhGDW024352 for ; Mon, 5 Feb 2007 08:43:17 -0600 Received: by lab41.emea.sgi.com (Postfix, from userid 1000) id 3E9325801C; Mon, 5 Feb 2007 15:00:38 +0000 (GMT) To: xfs@oss.sgi.com Subject: TAKE 960791 - Fix assertion in xfs_attr_shortform_remove() Message-Id: <20070205150038.3E9325801C@lab41.emea.sgi.com> Date: Mon, 5 Feb 2007 15:00:38 +0000 (GMT) From: lachlan@lab41.emea.sgi.com (Lachlan McIlroy) X-archive-position: 10569 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: lachlan@lab41.emea.sgi.com Precedence: bulk X-list: xfs Content-Length: 543 Lines: 18 Fix assertion in xfs_attr_shortform_remove(). Date: Tue Feb 6 01:40:20 AEDT 2007 Workarea: vpn-emea-sw-emea-160-32.emea.sgi.com:/home/lachlan/isms/2.6.x-null Inspected by: bnaujok Author: lachlan The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28021a fs/xfs/xfs_attr_leaf.c - 1.106 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_attr_leaf.c.diff?r1=text&tr1=1.106&r2=text&tr2=1.105&f=h - Fix assertion in xfs_attr_shortform_remove(). From owner-xfs@oss.sgi.com Mon Feb 5 10:00:21 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 10:00:32 -0800 (PST) X-Spam-oss-Status: No, score=0.0 required=5.0 tests=BAYES_50,SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15I0I3c025060 for ; Mon, 5 Feb 2007 10:00:21 -0800 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1HE88I-0007a3-4J for linux-xfs@oss.sgi.com; Mon, 05 Feb 2007 19:00:02 +0100 Received: from c-134-232-3.f.dsl.de.ignite.net ([62.134.232.3]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Feb 2007 19:00:02 +0100 Received: from bernd-schubert by c-134-232-3.f.dsl.de.ignite.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Feb 2007 19:00:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: linux-xfs@oss.sgi.com From: Bernd Schubert Subject: Re: XFS "no space left" problem Date: Mon, 05 Feb 2007 18:58:04 +0100 Message-ID: References: <20070203183723.GA1652@dunno.espix.org> <20070203233828.GD44411608@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-134-232-3.f.dsl.de.ignite.net User-Agent: KNode/0.10.4 X-archive-position: 10571 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: bernd-schubert@gmx.de Precedence: bulk X-list: xfs Content-Length: 716 Lines: 18 David Chinner wrote: > Or get a 64bit machine and use inode64. ;) David, can you tell more in detail what you mean with "use inode64"? We also just migrated our server to xfs, the largest partition has a size of 4TB. Lets say in the future a problem occurs and we could solve this by a 64-bit system? Migrating to 64-bit wouldn't be difficult, since the server systems are already opterons. Only since we never bothered to migrate the installation to x86_64 its not 64-bit yet. Would we need to tell xfs somehow that it update its internal values to 64-bit integers or will it do that automatically? Btw, if you need 64-bit integers, why don't you use long long, or even better with C99 int64_t? Thanks, Bernd From owner-xfs@oss.sgi.com Mon Feb 5 14:08:43 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 14:08:47 -0800 (PST) X-Spam-oss-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15M8e3c009160 for ; Mon, 5 Feb 2007 14:08:42 -0800 Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1HEB5N-0001bl-Sq; Mon, 05 Feb 2007 21:09:13 +0000 Date: Mon, 5 Feb 2007 21:09:13 +0000 From: Christoph Hellwig To: David Chinner Cc: Christoph Hellwig , xfs-dev@sgi.com, xfs@oss.sgi.com Subject: Re: Review: freezing sometimes leaves the log dirty Message-ID: <20070205210913.GA6062@infradead.org> References: <20070130220326.GM33919298@melbourne.sgi.com> <20070202114623.GA23187@infradead.org> <20070202140706.GX33919298@melbourne.sgi.com> <20070205210245.GP44411608@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070205210245.GP44411608@melbourne.sgi.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-archive-position: 10577 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Content-Length: 267 Lines: 9 On Tue, Feb 06, 2007 at 08:02:45AM +1100, David Chinner wrote: > On Sat, Feb 03, 2007 at 01:07:06AM +1100, David Chinner wrote: > > Patch below cleans all this up and also fixes the 2.4 tree as well. > > Can I get an ack from someone on this? > Looks good to me. From owner-xfs@oss.sgi.com Mon Feb 5 14:38:45 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 14:38:53 -0800 (PST) X-Spam-oss-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.2.0-pre1-r497472 Received: from pne-smtpout3-sn1.fre.skanova.net (pne-smtpout3-sn1.fre.skanova.net [81.228.11.120]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15Mcf3c014086 for ; Mon, 5 Feb 2007 14:38:45 -0800 Received: from safari.iki.fi (80.223.106.128) by pne-smtpout3-sn1.fre.skanova.net (7.2.075) id 45AE1FD5001033AC for xfs@oss.sgi.com; Mon, 5 Feb 2007 22:29:06 +0100 Received: (qmail 9810 invoked by uid 500); 5 Feb 2007 21:29:06 -0000 Date: Mon, 5 Feb 2007 23:29:06 +0200 From: Sami Farin To: xfs@oss.sgi.com Subject: Re: Spam on list? Message-ID: <20070205212906.GA6096@m.safari.iki.fi> Mail-Followup-To: Sami Farin , xfs@oss.sgi.com References: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> <200702051306.34279.ak@suse.de> <45C73CB9.5000402@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <45C73CB9.5000402@sandeen.net> User-Agent: Mutt/1.5.13 (2006-08-11) X-archive-position: 10579 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: safari-xfs@safari.iki.fi Precedence: bulk X-list: xfs Content-Length: 2166 Lines: 51 On Mon, Feb 05, 2007 at 08:18:33 -0600, Eric Sandeen wrote: > Andi Kleen wrote: > >On Monday 05 February 2007 12:52, Martin Schröder wrote: > >>05 Feb 2007 11:32:25 +0100, Andi Kleen : > >>>Please don't do that. It means nothing can be cross posted > >>>from l-k anymore, which would be pretty bad. > >>Then set up a list admin who can approve such postings. > > > >That adds unacceptable latency. Also lists who spam senders > >with bounce messages tend to be dropped quickly from cc lists. > > > >Also you couldn't list xfs@ as bug report address anymore because > >bug report addresses must be available to everyone. > > > >In general it's a bad idea. > > > >-Andi > > > > Well, I agree w/ those arguments too, Andi. > > I honestly don't know why oss seems to have so much more spam than, say, > LKML. It is getting to a really bad level, and I sympathize with those > whose inboxes are bombarded, too. Those 419 scams and phishes are caught by for example a bayesian filter. That's what I have done since 2003. As for the "only subscribers can post" as an anti-spam measure, I can say that for those mailing lists where they are doing it, the emails from non-subscribers go to /dev/null and if you contact owner, it goes, too, because you are not subscribed (!!) OR they just tell you to screw off. After waiting for a week. If they feel like it. This is not to say that xfs ml would be doing this /dev/nulling , this is just my general feeling about this anti-spam measure and its usability. Besides, I use different (secret) subscription email address for mailing lists than in the From header field when I write to the list. This way it's easy to have different anti-spam measures for subscription email (e.g., none) than for the email in From (e.g., I can reject out-of-office notices and other brokeness). If I had to use the same email for both purposes, I couldn't for example reject based on 419 scammers' IP addresses found in Received etc. header fields because then I would get auto-unsubscribed from this mailing list when ecartis thinks my email is broken. -- Do what you love because life is too short for anything else. From owner-xfs@oss.sgi.com Mon Feb 5 15:47:57 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 15:48:03 -0800 (PST) X-Spam-oss-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00, SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l15Nlt3c026057 for ; Mon, 5 Feb 2007 15:47:56 -0800 Received: from [10.0.0.4] (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id A960118013A80; Mon, 5 Feb 2007 17:47:54 -0600 (CST) Message-ID: <45C7C228.2090609@sandeen.net> Date: Mon, 05 Feb 2007 17:47:52 -0600 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: nscott@aconex.com CC: Andi Kleen , =?UTF-8?B?TWFydGluIFNjaHLDtmRlcg==?= , Justin Piszcz , xfs@oss.sgi.com Subject: Re: Spam on list? References: <68c491a60702050352t278e8381l72795ed9ea880029@mail.gmail.com> <200702051306.34279.ak@suse.de> <45C73CB9.5000402@sandeen.net> <1170712730.18017.452.camel@edge> In-Reply-To: <1170712730.18017.452.camel@edge> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-archive-position: 10580 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Content-Length: 794 Lines: 22 Nathan Scott wrote: > On Mon, 2007-02-05 at 08:18 -0600, Eric Sandeen wrote: >> Andi Kleen wrote: >>> On Monday 05 February 2007 12:52, Martin Schröder wrote: >>>> 05 Feb 2007 11:32:25 +0100, Andi Kleen : >>>>> Please don't do that. It means nothing can be cross posted >>>>> from l-k anymore, which would be pretty bad. >>>> Then set up a list admin who can approve such postings. >>> That adds unacceptable latency. Also lists who spam senders >>> with bounce messages tend to be dropped quickly from cc lists. >>> >>> Also you couldn't list xfs@ as bug report address anymore because >>> bug report addresses must be available to everyone. >>> >>> In general it's a bad idea. > > *nod*, it really cannot become a closed list. Ok ok everyone, it was just a thought ;-) -Eric From owner-xfs@oss.sgi.com Mon Feb 5 17:25:42 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 17:25:49 -0800 (PST) X-Spam-oss-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_05, DATE_IN_PAST_12_24,SPF_HELO_PASS autolearn=no version=3.2.0-pre1-r497472 Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l161Pd3c012032 for ; Mon, 5 Feb 2007 17:25:41 -0800 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1HEF51-00012E-9n for linux-xfs@oss.sgi.com; Tue, 06 Feb 2007 02:25:07 +0100 Received: from ppp79-69.lns1.mel3.internode.on.net ([59.167.79.69]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Feb 2007 02:25:02 +0100 Received: from jasonjgw by ppp79-69.lns1.mel3.internode.on.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Feb 2007 02:25:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: linux-xfs@oss.sgi.com From: Jason White Subject: Re: Spam on list? Date: Mon, 5 Feb 2007 09:59:14 +0000 (UTC) Message-ID: References: <45C62982.1090206@sandeen.net> X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: ppp79-69.lns1.mel3.internode.on.net User-Agent: slrn/0.9.8.1pl1 (Debian) X-archive-position: 10582 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: jasonjgw@internode.on.net Precedence: bulk X-list: xfs Content-Length: 681 Lines: 19 On 2007-02-05, Andi Kleen wrote: > Eric Sandeen writes: >> >> I think it may be time to revisit that decision. It's gotten really >> bad lately. I agree. > > Please don't do that. It means nothing can be cross posted > from l-k anymore, which would be pretty bad. Posting from Gmane (nntp://news.gmane.org/) is also desirable, and (relatively) safe as it implements a challenge/response procedure and has other anti-spam controls. Is it possible to configure the list server to be more selective about who can post (i.e., detecting header contents that include known good lists, Gmane postings, etc.)? There's always "greylisting", too. From owner-xfs@oss.sgi.com Mon Feb 5 22:47:10 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 22:47:18 -0800 (PST) X-Spam-oss-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l166l63c021473 for ; Mon, 5 Feb 2007 22:47:08 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id RAA13875; Tue, 6 Feb 2007 17:47:02 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 4E7B358FF657; Tue, 6 Feb 2007 17:47:02 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960192 - XFS sysctl cleanup Message-Id: <20070206064702.4E7B358FF657@chook.melbourne.sgi.com> Date: Tue, 6 Feb 2007 17:47:02 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10583 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 776 Lines: 22 XFS sysctl cleanups Removes unneeded sysctl insert at head behaviour. Cleans up sysctl definitions to use C99 initialisers. Patch provided by Eric W. Biederman. Signed-off-by: Eric W. Biederman Date: Tue Feb 6 17:46:02 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: dgc,ebiederm@xmission.com The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28031a fs/xfs/linux-2.6/xfs_sysctl.c - 1.40 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_sysctl.c.diff?r1=text&tr1=1.40&r2=text&tr2=1.39&f=h - sysctl cleanup patch provided by Eric W. Biederman. Signed-off-by: Eric W. Biederman From owner-xfs@oss.sgi.com Mon Feb 5 23:20:45 2007 Received: with ECARTIS (v1.0.0; list xfs); Mon, 05 Feb 2007 23:20:49 -0800 (PST) X-Spam-oss-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l167Kg3c027848 for ; Mon, 5 Feb 2007 23:20:44 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id SAA14634; Tue, 6 Feb 2007 18:20:37 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 1ECC458FF657; Tue, 6 Feb 2007 18:20:37 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960868 - Clean up use of vfs attr flags Message-Id: <20070206072037.1ECC458FF657@chook.melbourne.sgi.com> Date: Tue, 6 Feb 2007 18:20:37 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10585 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 788 Lines: 23 Clean up use of VFS attr flags Use the the generic VFS attr flags where appropriate instead of open coding them to the same values. Patch provided by Eric Sandeen. Signed-off-by: Eric Sandeen Date: Tue Feb 6 18:19:58 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: dgc,sandeen@sandeen.net,hch@infradead.org The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28033a fs/xfs/linux-2.6/xfs_ioctl.c - 1.143 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_ioctl.c.diff?r1=text&tr1=1.143&r2=text&tr2=1.142&f=h - Use generic VFS attr flags rather than open coding them. Signed-off-by: Eric Sandeen From owner-xfs@oss.sgi.com Tue Feb 6 00:09:18 2007 Received: with ECARTIS (v1.0.0; list xfs); Tue, 06 Feb 2007 00:09:22 -0800 (PST) X-Spam-oss-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l1689F3c002603 for ; Tue, 6 Feb 2007 00:09:17 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id TAA15701; Tue, 6 Feb 2007 19:09:10 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 678B058FF657; Tue, 6 Feb 2007 19:09:10 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960196 - remove unused "firstblock" arg from xfs_bmap_finish() Message-Id: <20070206080910.678B058FF657@chook.melbourne.sgi.com> Date: Tue, 6 Feb 2007 19:09:10 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10586 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 2816 Lines: 63 Remove unused argument to xfs_bmap_finish The firstblock argument to xfs_bmap_finish is not used by that function. Remove it and cleanup the code a bit. Patch provided by Eric Sandeen. Signed-off-by: Eric Sandeen Date: Tue Feb 6 18:59:03 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: dgc,sandeen@sandeen.net The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28034a fs/xfs/xfs_vnodeops.c - 1.688 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.688&r2=text&tr2=1.687&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_rtalloc.c - 1.104 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rtalloc.c.diff?r1=text&tr1=1.104&r2=text&tr2=1.103&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_inode.c - 1.459 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.459&r2=text&tr2=1.458&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap.h - 1.98 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap.h.diff?r1=text&tr1=1.98&r2=text&tr2=1.97&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap.c - 1.362 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap.c.diff?r1=text&tr1=1.362&r2=text&tr2=1.361&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_rename.c - 1.69 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rename.c.diff?r1=text&tr1=1.69&r2=text&tr2=1.68&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_attr.c - 1.142 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_attr.c.diff?r1=text&tr1=1.142&r2=text&tr2=1.141&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/quota/xfs_dquot.c - 1.27 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/quota/xfs_dquot.c.diff?r1=text&tr1=1.27&r2=text&tr2=1.26&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen fs/xfs/xfs_iomap.c - 1.49 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_iomap.c.diff?r1=text&tr1=1.49&r2=text&tr2=1.48&f=h - Remove unused firstblock argument from xfs_bmap_finish. Signed-off-by: Eric Sandeen From owner-xfs@oss.sgi.com Tue Feb 6 15:56:47 2007 Received: with ECARTIS (v1.0.0; list xfs); Tue, 06 Feb 2007 15:56:52 -0800 (PST) X-Spam-oss-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l16Nui3c009855 for ; Tue, 6 Feb 2007 15:56:46 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id KAA10568; Wed, 7 Feb 2007 10:56:38 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 4300558C4C27; Wed, 7 Feb 2007 10:56:38 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 959267 - bad clientid during log replay of snapshot image Message-Id: <20070206235638.4300558C4C27@chook.melbourne.sgi.com> Date: Wed, 7 Feb 2007 10:56:38 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10589 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 1619 Lines: 38 Make freeze code a little cleaner. Fixes a few small issues (mostly cosmetic) that were picked up during the review cycle for the last set of freeze path changes. Date: Wed Feb 7 10:56:10 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: hch@infradead.org The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28035a fs/xfs/xfs_vfsops.c - 1.515 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vfsops.c.diff?r1=text&tr1=1.515&r2=text&tr2=1.514&f=h - Convert SYNC_DIO_WAIT to SYNC_IOWAIT as it really waits for all I/O, not just direct I/O. fs/xfs/linux-2.6/xfs_vfs.h - 1.69 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vfs.h.diff?r1=text&tr1=1.69&r2=text&tr2=1.68&f=h - Convert SYNC_DIO_WAIT to SYNC_IOWAIT as it really waits for all I/O, not just direct I/O. fs/xfs/linux-2.6/xfs_super.c - 1.378 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.378&r2=text&tr2=1.377&f=h - Convert SYNC_DIO_WAIT to SYNC_IOWAIT as it really waits for all I/O, not just direct I/O. fs/xfs/linux-2.4/xfs_vfs.h - 1.65 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.4/xfs_vfs.h.diff?r1=text&tr1=1.65&r2=text&tr2=1.64&f=h - add/remove SYNC_* flags for freeze path changes. fs/xfs/linux-2.4/xfs_super.c - 1.334 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.4/xfs_super.c.diff?r1=text&tr1=1.334&r2=text&tr2=1.333&f=h - Use new flush ordering and semantics in the freeze path. From owner-xfs@oss.sgi.com Tue Feb 6 16:35:45 2007 Received: with ECARTIS (v1.0.0; list xfs); Tue, 06 Feb 2007 16:35:49 -0800 (PST) X-Spam-oss-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l170Zg3c018388 for ; Tue, 6 Feb 2007 16:35:44 -0800 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id LAA12077; Wed, 7 Feb 2007 11:35:37 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id 1F36858C4C27; Wed, 7 Feb 2007 11:35:37 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960897 - Remove a bunch of unused functions from XFS Message-Id: <20070207003537.1F36858C4C27@chook.melbourne.sgi.com> Date: Wed, 7 Feb 2007 11:35:37 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10591 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 2468 Lines: 61 Remove a bunch of unused functions from XFS. Patch provided by Eric Sandeen (sandeen@sandeen.net). Signed-off-by: Eric Sandeen Date: Wed Feb 7 11:35:11 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: dgc,sandeen@sandeen.net The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28038a fs/xfs/xfs_da_btree.c - 1.174 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_da_btree.c.diff?r1=text&tr1=1.174&r2=text&tr2=1.173&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_da_btree.h - 1.66 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_da_btree.h.diff?r1=text&tr1=1.66&r2=text&tr2=1.65&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_rtalloc.h - 1.29 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rtalloc.h.diff?r1=text&tr1=1.29&r2=text&tr2=1.28&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_rtalloc.c - 1.105 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rtalloc.c.diff?r1=text&tr1=1.105&r2=text&tr2=1.104&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap_btree.h - 1.76 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap_btree.h.diff?r1=text&tr1=1.76&r2=text&tr2=1.75&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap_btree.c - 1.160 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap_btree.c.diff?r1=text&tr1=1.160&r2=text&tr2=1.159&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_error.c - 1.55 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_error.c.diff?r1=text&tr1=1.55&r2=text&tr2=1.54&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_error.h - 1.47 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_error.h.diff?r1=text&tr1=1.47&r2=text&tr2=1.46&f=h - Remove unused functions. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap.c - 1.364 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap.c.diff?r1=text&tr1=1.364&r2=text&tr2=1.363&f=h - Remove unused functions. Signed-off-by: Eric Sandeen From owner-xfs@oss.sgi.com Tue Feb 6 17:19:30 2007 Received: with ECARTIS (v1.0.0; list xfs); Tue, 06 Feb 2007 17:19:35 -0800 (PST) X-Spam-oss-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.0-pre1-r497472 Received: from omx1.sgi.com (omx1.americas.sgi.com [198.149.16.13]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l171JR3c023704 for ; Tue, 6 Feb 2007 17:19:29 -0800 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by omx1.sgi.com (8.12.10/8.12.9/linux-outbound_gateway-1.1) with SMTP id l170RSDW021405 for ; Tue, 6 Feb 2007 18:27:29 -0600 Received: from chook.melbourne.sgi.com (chook.melbourne.sgi.com [134.14.54.237]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id LAA11709; Wed, 7 Feb 2007 11:27:21 +1100 Received: by chook.melbourne.sgi.com (Postfix, from userid 16346) id D9D8F58C4C27; Wed, 7 Feb 2007 11:27:21 +1100 (EST) To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com Subject: TAKE 960197 - remove unused arguments from the XFS_BTREE_*_ADDR functions Message-Id: <20070207002721.D9D8F58C4C27@chook.melbourne.sgi.com> Date: Wed, 7 Feb 2007 11:27:21 +1100 (EST) From: dgc@sgi.com (David Chinner) X-archive-position: 10592 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 2950 Lines: 63 Remove unused arguments from the XFS_BTREE_*_ADDR macros. It makes it incrementally clearer to read the code when the top of a macro spaghetti-pile only receives the 3 arguments it uses, rather than 2 extra ones which are not used. Also when you start pulling this thread out of the sweater (i.e. remove unused args from XFS_BTREE_*_ADDR), a couple other third arms etc fall off too. If they're not used in the macro, then they sometimes don't need to be passed to the function calling the macro either, etc.... Patch provided by Eric Sandeen (sandeen@sandeen.net). Signed-off-by: Eric Sandeen Date: Wed Feb 7 11:26:40 AEDT 2007 Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs Inspected by: dgc,sandeen@sandeen.net The following file(s) were checked into: longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb Modid: xfs-linux-melb:xfs-kern:28037a fs/xfs/xfsidbg.c - 1.311 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfsidbg.c.diff?r1=text&tr1=1.311&r2=text&tr2=1.310&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_ialloc_btree.h - 1.32 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_ialloc_btree.h.diff?r1=text&tr1=1.32&r2=text&tr2=1.31&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap_btree.h - 1.75 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap_btree.h.diff?r1=text&tr1=1.75&r2=text&tr2=1.74&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap_btree.c - 1.159 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap_btree.c.diff?r1=text&tr1=1.159&r2=text&tr2=1.158&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_btree.h - 1.65 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_btree.h.diff?r1=text&tr1=1.65&r2=text&tr2=1.64&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_fsops.c - 1.121 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_fsops.c.diff?r1=text&tr1=1.121&r2=text&tr2=1.120&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_bmap.c - 1.363 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_bmap.c.diff?r1=text&tr1=1.363&r2=text&tr2=1.362&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen fs/xfs/xfs_alloc_btree.h - 1.30 - changed http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_alloc_btree.h.diff?r1=text&tr1=1.30&r2=text&tr2=1.29&f=h - Remove unused arguments from XFS_BTREE_*_ADDR macros. Signed-off-by: Eric Sandeen From owner-xfs@oss.sgi.com Tue Feb 6 20:55:17 2007 Received: with ECARTIS (v1.0.0; list xfs); Tue, 06 Feb 2007 20:55:26 -0800 (PST) X-Spam-oss-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00, SPF_HELO_PASS autolearn=ham version=3.2.0-pre1-r497472 Received: from sandeen.net (sandeen.net [209.173.210.139]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id l174tF3c022565 for ; Tue, 6 Feb 2007 20:55:16 -0800 Received: from [10.0.0.4] (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id 4518518003EF5 for ; Tue, 6 Feb 2007 22:55:11 -0600 (CST) Message-ID: <45C95BAF.6080005@sandeen.net> Date: Tue, 06 Feb 2007 22:55:11 -0600 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: xfs@oss.sgi.com Subject: [PATCH] remove unused "lsn" argument of xfs_trans_commit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 10594 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Content-Length: 19162 Lines: 627 The last argument "lsn" of xfs_trans_commit() is always called with NULL. dmapi/xfs_dm.c | 4 ++-- quota/xfs_dquot.c | 3 +-- quota/xfs_qm.c | 5 ++--- quota/xfs_qm_syscalls.c | 6 +++--- xfs_attr.c | 12 ++++-------- xfs_attr_leaf.c | 2 +- xfs_bmap.c | 4 ++-- xfs_dfrag.c | 2 +- xfs_fsops.c | 4 ++-- xfs_inode.c | 2 +- xfs_iomap.c | 7 +++---- xfs_log_recover.c | 4 ++-- xfs_mount.c | 2 +- xfs_qmops.c | 2 +- xfs_rename.c | 2 +- xfs_rtalloc.c | 6 +++--- xfs_rw.c | 4 ++-- xfs_trans.c | 6 ------ xfs_trans.h | 4 +--- xfs_utils.c | 5 ++--- xfs_vfsops.c | 2 +- xfs_vnodeops.c | 33 ++++++++++++++++----------------- 22 files changed, 52 insertions(+), 69 deletions(-) Signed-off-by: Eric Sandeen --- Index: linux/fs/xfs/dmapi/xfs_dm.c =================================================================== --- linux/fs/xfs.orig/dmapi/xfs_dm.c +++ linux/fs/xfs/dmapi/xfs_dm.c @@ -1168,7 +1168,7 @@ xfs_dm_f_set_eventlist( xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); VN_HOLD(vp); - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); return(0); } @@ -3021,7 +3021,7 @@ xfs_dm_set_region( xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); VN_HOLD(vp); - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); /* Return the proper value for *exactflagp depending upon whether or not we "changed" the user's managed region. In other words, if the user Index: linux/fs/xfs/quota/xfs_dquot.c =================================================================== --- linux/fs/xfs.orig/quota/xfs_dquot.c +++ linux/fs/xfs/quota/xfs_dquot.c @@ -753,8 +753,7 @@ xfs_qm_idtodq( goto error0; } if (tp) { - if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, - NULL))) + if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES))) goto error1; } Index: linux/fs/xfs/quota/xfs_qm.c =================================================================== --- linux/fs/xfs.orig/quota/xfs_qm.c +++ linux/fs/xfs/quota/xfs_qm.c @@ -1453,8 +1453,7 @@ xfs_qm_qino_alloc( XFS_SB_UNLOCK(mp, s); xfs_mod_sb(tp, sbfields); - if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, - NULL))) { + if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES))) { xfs_fs_cmn_err(CE_ALERT, mp, "XFS qino_alloc failed!"); return error; } @@ -2405,7 +2404,7 @@ xfs_qm_write_sb_changes( } xfs_mod_sb(tp, flags); - (void) xfs_trans_commit(tp, 0, NULL); + (void) xfs_trans_commit(tp, 0); return 0; } Index: linux/fs/xfs/quota/xfs_qm_syscalls.c =================================================================== --- linux/fs/xfs.orig/quota/xfs_qm_syscalls.c +++ linux/fs/xfs/quota/xfs_qm_syscalls.c @@ -735,7 +735,7 @@ xfs_qm_scall_setqlim( xfs_trans_log_dquot(tp, dqp); xfs_dqtrace_entry(dqp, "Q_SETQLIM: COMMIT"); - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); xfs_qm_dqprint(dqp); xfs_qm_dqrele(dqp); mutex_unlock(&(XFS_QI_QOFFLOCK(mp))); @@ -809,7 +809,7 @@ xfs_qm_log_quotaoff_end( * We don't care about quotoff's performance. */ xfs_trans_set_sync(tp); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); return (error); } @@ -852,7 +852,7 @@ xfs_qm_log_quotaoff( * We don't care about quotoff's performance. */ xfs_trans_set_sync(tp); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); error0: if (error) { Index: linux/fs/xfs/xfs_attr.c =================================================================== --- linux/fs/xfs.orig/xfs_attr.c +++ linux/fs/xfs/xfs_attr.c @@ -328,8 +328,7 @@ xfs_attr_set_int(xfs_inode_t *dp, const xfs_trans_set_sync(args.trans); } err2 = xfs_trans_commit(args.trans, - XFS_TRANS_RELEASE_LOG_RES, - NULL); + XFS_TRANS_RELEASE_LOG_RES); xfs_iunlock(dp, XFS_ILOCK_EXCL); /* @@ -397,8 +396,7 @@ xfs_attr_set_int(xfs_inode_t *dp, const * Commit the last in the sequence of transactions. */ xfs_trans_log_inode(args.trans, dp, XFS_ILOG_CORE); - error = xfs_trans_commit(args.trans, XFS_TRANS_RELEASE_LOG_RES, - NULL); + error = xfs_trans_commit(args.trans, XFS_TRANS_RELEASE_LOG_RES); xfs_iunlock(dp, XFS_ILOCK_EXCL); /* @@ -544,8 +542,7 @@ xfs_attr_remove_int(xfs_inode_t *dp, con * Commit the last in the sequence of transactions. */ xfs_trans_log_inode(args.trans, dp, XFS_ILOG_CORE); - error = xfs_trans_commit(args.trans, XFS_TRANS_RELEASE_LOG_RES, - NULL); + error = xfs_trans_commit(args.trans, XFS_TRANS_RELEASE_LOG_RES); xfs_iunlock(dp, XFS_ILOCK_EXCL); /* @@ -859,8 +856,7 @@ xfs_attr_inactive(xfs_inode_t *dp) * Commit the last in the sequence of transactions. */ xfs_trans_log_inode(trans, dp, XFS_ILOG_CORE); - error = xfs_trans_commit(trans, XFS_TRANS_RELEASE_LOG_RES, - NULL); + error = xfs_trans_commit(trans, XFS_TRANS_RELEASE_LOG_RES); xfs_iunlock(dp, XFS_ILOCK_EXCL); return(error); Index: linux/fs/xfs/xfs_attr_leaf.c =================================================================== --- linux/fs/xfs.orig/xfs_attr_leaf.c +++ linux/fs/xfs/xfs_attr_leaf.c @@ -3053,7 +3053,7 @@ xfs_attr_rolltrans(xfs_trans_t **transp, * is in progress. The caller takes the responsibility to cancel * the duplicate transaction that gets returned. */ - if ((error = xfs_trans_commit(trans, 0, NULL))) + if ((error = xfs_trans_commit(trans, 0))) return (error); trans = *transp; Index: linux/fs/xfs/xfs_bmap.c =================================================================== --- linux/fs/xfs.orig/xfs_bmap.c +++ linux/fs/xfs/xfs_bmap.c @@ -4071,7 +4071,7 @@ xfs_bmap_add_attrfork( } if ((error = xfs_bmap_finish(&tp, &flist, &committed))) goto error2; - error = xfs_trans_commit(tp, XFS_TRANS_PERM_LOG_RES, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_PERM_LOG_RES); ASSERT(ip->i_df.if_ext_max == XFS_IFORK_DSIZE(ip) / (uint)sizeof(xfs_bmbt_rec_t)); return error; @@ -4227,7 +4227,7 @@ xfs_bmap_finish( logres = ntp->t_log_res; logcount = ntp->t_log_count; ntp = xfs_trans_dup(*tp); - error = xfs_trans_commit(*tp, 0, NULL); + error = xfs_trans_commit(*tp, 0); *tp = ntp; *committed = 1; /* Index: linux/fs/xfs/xfs_dfrag.c =================================================================== --- linux/fs/xfs.orig/xfs_dfrag.c +++ linux/fs/xfs/xfs_dfrag.c @@ -382,7 +382,7 @@ xfs_swap_extents( xfs_trans_set_sync(tp); } - error = xfs_trans_commit(tp, XFS_TRANS_SWAPEXT, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_SWAPEXT); locked = 0; error0: Index: linux/fs/xfs/xfs_fsops.c =================================================================== --- linux/fs/xfs.orig/xfs_fsops.c +++ linux/fs/xfs/xfs_fsops.c @@ -346,7 +346,7 @@ xfs_growfs_data_private( xfs_trans_mod_sb(tp, XFS_TRANS_SB_FDBLOCKS, nfree); if (dpct) xfs_trans_mod_sb(tp, XFS_TRANS_SB_IMAXPCT, dpct); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); if (error) { return error; } @@ -605,7 +605,7 @@ xfs_fs_log_dummy( xfs_trans_ihold(tp, ip); xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); xfs_trans_set_sync(tp); - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); xfs_iunlock(ip, XFS_ILOCK_EXCL); } Index: linux/fs/xfs/xfs_inode.c =================================================================== --- linux/fs/xfs.orig/xfs_inode.c +++ linux/fs/xfs/xfs_inode.c @@ -1746,7 +1746,7 @@ xfs_itruncate_finish( xfs_trans_log_inode(ntp, ip, XFS_ILOG_CORE); } ntp = xfs_trans_dup(ntp); - (void) xfs_trans_commit(*tp, 0, NULL); + (void) xfs_trans_commit(*tp, 0); *tp = ntp; error = xfs_trans_reserve(ntp, 0, XFS_ITRUNCATE_LOG_RES(mp), 0, XFS_TRANS_PERM_LOG_RES, Index: linux/fs/xfs/xfs_iomap.c =================================================================== --- linux/fs/xfs.orig/xfs_iomap.c +++ linux/fs/xfs/xfs_iomap.c @@ -543,7 +543,7 @@ xfs_iomap_write_direct( error = xfs_bmap_finish(&tp, &free_list, &committed); if (error) goto error0; - error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES); if (error) goto error_out; @@ -840,8 +840,7 @@ xfs_iomap_write_allocate( if (error) goto trans_cancel; - error = xfs_trans_commit(tp, - XFS_TRANS_RELEASE_LOG_RES, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES); if (error) goto error0; @@ -948,7 +947,7 @@ xfs_iomap_write_unwritten( if (error) goto error_on_bmapi_transaction; - error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES); xfs_iunlock(ip, XFS_ILOCK_EXCL); if (error) return XFS_ERROR(error); Index: linux/fs/xfs/xfs_log_recover.c =================================================================== --- linux/fs/xfs.orig/xfs_log_recover.c +++ linux/fs/xfs/xfs_log_recover.c @@ -3016,7 +3016,7 @@ xlog_recover_process_efi( } efip->efi_flags |= XFS_EFI_RECOVERED; - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); } /* @@ -3143,7 +3143,7 @@ xlog_recover_clear_agi_bucket( xfs_trans_log_buf(tp, agibp, offset, (offset + sizeof(xfs_agino_t) - 1)); - (void) xfs_trans_commit(tp, 0, NULL); + (void) xfs_trans_commit(tp, 0); } /* Index: linux/fs/xfs/xfs_mount.c =================================================================== --- linux/fs/xfs.orig/xfs_mount.c +++ linux/fs/xfs/xfs_mount.c @@ -1653,7 +1653,7 @@ xfs_mount_log_sbunit( return; } xfs_mod_sb(tp, fields); - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); } Index: linux/fs/xfs/xfs_qmops.c =================================================================== --- linux/fs/xfs.orig/xfs_qmops.c +++ linux/fs/xfs/xfs_qmops.c @@ -78,7 +78,7 @@ xfs_mount_reset_sbqflags(xfs_mount_t *mp return error; } xfs_mod_sb(tp, XFS_SB_QFLAGS); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); return error; } Index: linux/fs/xfs/xfs_rename.c =================================================================== --- linux/fs/xfs.orig/xfs_rename.c +++ linux/fs/xfs/xfs_rename.c @@ -584,7 +584,7 @@ xfs_rename( * trans_commit will unlock src_ip, target_ip & decrement * the vnode references. */ - error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, NULL); + error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES); if (target_ip != NULL) { xfs_refcache_purge_ip(target_ip); IRELE(target_ip); Index: linux/fs/xfs/xfs_rtalloc.c =================================================================== --- linux/fs/xfs.orig/xfs_rtalloc.c +++ linux/fs/xfs/xfs_rtalloc.c @@ -150,7 +150,7 @@ xfs_growfs_rt_alloc( error = xfs_bmap_finish(&tp, &flist, &committed); if (error) goto error_exit; - xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES, NULL); + xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES); /* * Now we need to clear the allocated blocks. * Do this one block per transaction, to keep it simple. @@ -187,7 +187,7 @@ xfs_growfs_rt_alloc( /* * Commit the transaction. */ - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); } /* * Go on to the next extent, if any. @@ -2042,7 +2042,7 @@ xfs_growfs_rt( /* * Commit the transaction. */ - xfs_trans_commit(tp, 0, NULL); + xfs_trans_commit(tp, 0); } if (error) Index: linux/fs/xfs/xfs_rw.c =================================================================== --- linux/fs/xfs.orig/xfs_rw.c +++ linux/fs/xfs/xfs_rw.c @@ -83,7 +83,7 @@ xfs_write_clear_setuid( } xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); xfs_trans_set_sync(tp); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); xfs_iunlock(ip, XFS_ILOCK_EXCL); return 0; } @@ -164,7 +164,7 @@ xfs_write_sync_logforce( xfs_trans_ihold(tp, ip); xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); xfs_trans_set_sync(tp); - error = xfs_trans_commit(tp, 0, NULL); + error = xfs_trans_commit(tp, 0); xfs_iunlock(ip, XFS_ILOCK_EXCL); } } Index: linux/fs/xfs/xfs_trans.c =================================================================== --- linux/fs/xfs.orig/xfs_trans.c +++ linux/fs/xfs/xfs_trans.c @@ -753,7 +753,6 @@ int _xfs_trans_commit( xfs_trans_t *tp, uint flags, - xfs_lsn_t *commit_lsn_p, int *log_flushed) { xfs_log_iovec_t *log_vector; @@ -812,8 +811,6 @@ shut_us_down: xfs_trans_free_busy(tp); xfs_trans_free(tp); XFS_STATS_INC(xs_trans_empty); - if (commit_lsn_p) - *commit_lsn_p = commit_lsn; return (shutdown); } ASSERT(tp->t_ticket != NULL); @@ -864,9 +861,6 @@ shut_us_down: kmem_free(log_vector, nvec * sizeof(xfs_log_iovec_t)); } - if (commit_lsn_p) - *commit_lsn_p = commit_lsn; - /* * If we got a log write error. Unpin the logitems that we * had pinned, clean up, free trans structure, and return error. Index: linux/fs/xfs/xfs_trans.h =================================================================== --- linux/fs/xfs.orig/xfs_trans.h +++ linux/fs/xfs/xfs_trans.h @@ -988,10 +988,8 @@ void xfs_trans_log_ef